229215 - [Spellcheck] Word marked as wrong if first letter is capitalized

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Oliver Klee]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20030729
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20031223

Spellchecker no longer accepts words that are in the dictionary if they are
capitalized in the mail.

Reproducible: Always

Steps to Reproduce:
1. Compose new mail.
2. Enter "This" as body.
3. Spellcheck using "English/United States".

Actual Results:  
"This" is marked as an unknown word.

Expected Results:  
"This" is recognized as a known word (as the spellchecker already has "this" in
the dictionary).

I don't remember this behaviour. Looks like this regressed in the last few days.

Comment 1

[Oliver Klee]

Please note: This is not the same as bug 128122 (unless this change of behavior
is intended). 

Comment 2

[Robert Accettura [:raccettura]]

I always though spellchecker wasn't case senstive.  AFAIK there were no checkins
to change such functionality either.

Comment 3

[Bill Gianopoulos [:WG9s]]

This regressed between the 12/19 and 12/23 bulds.  I would suspect either the
checkins for bug 225749 or bug 226756.

Comment 4

[Bill Gianopoulos [:WG9s]]

Verified under Windows/XP, The OS should be changed to All. And, in my opionion,
the severity should be major.  It is impossible to spellcheck an e-mail of
reasonable length with this bug without getting a totally obnoxious number of
false errors.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

This is from bug 226756. (next time, consider cc-ing the patch author)
taking.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

oops. Removing the caseconversion doesn't do any good :)

Comment 7

[Bill Gianopoulos [:WG9s]]

This affects Thunderbird version 0.5, which is due out soon.  Unfortunately
there is no blocking Thunderbird 0.5 status to request.  Could we get this
reviewed and checked in soon?

Comment 8

[Oliver Klee]

As far as I know, Thunderbird 0.5 will be taken from the 1.6 branch, which isn't
affected by this bug. If I'm wrong about this, please correct me.

Comment 9

[Alec Flett]

Comment on attachment 138029 [details] [diff] [review]
patch v1

personally, I think trying to cache mCaseConv is a waste. Just use the existing
code in nsUnicharUtils.h which caches a per-dll copy of nsICaseConversion in
some static code that you link in.

sr=alecf on this patch since it doesn't make the situation any worse, but I
suggest fixing that to just use the unicharutil_s.lib or whatever.

Comment 10

[Bill Gianopoulos [:WG9s]]

Re comment #8, the current official Thunderbird 0.5 alpha build has this issue,
that is what I was going by.  Scoott is on vacation so we really can't be sure.

Comment 11

[Oliver Klee]

*** Bug 229640 has been marked as a duplicate of this bug. ***

Comment 12

[Oliver Klee]

Ok, moving to Thunderbird.

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

Sigh. Moving back. This isn't thunderbird. This is a general spellcheck bug. It
even has a patch. What good is there in moving it to thunderbird, other then it
not getting fixed?

Comment 14

[Calum Mackay]

*** Bug 229744 has been marked as a duplicate of this bug. ***

Comment 15

[Oliver Klee]

*** Bug 229754 has been marked as a duplicate of this bug. ***

Comment 16

[[e-mail]]

Comment on attachment 138029 [details] [diff] [review]
patch v1

hm yes :)

r=me

Comment 17

[Michiel van Leeuwen (email: mvl+moz@)]

Checked in.

Comment 18

[Joe Infla]

*** Bug 230033 has been marked as a duplicate of this bug. ***

Comment 19

[Oliver Klee]

*** Bug 230226 has been marked as a duplicate of this bug. ***

Comment 20

[timeless]

*** Bug 229506 has been marked as a duplicate of this bug. ***