22943 - hitting "attemping to process events on the wrong thread" assertion on the mac a ton of times

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

> I just did a clean build on my mac, and as soon as I click on my imap
> inbox (and get the password dialog) I get a ton of asserts from
>
> "nsEventQueue.cpp" line 194"
>
> NS_ASSERTION(correctThread, "attemping to process events on the wrong
> thread");

dougt's comments: "the mac event loop is still hosed (I never fixed it).  Assign
the bug to me and I will see that it gets fixed."

Comment 1

[Doug Turner (:dougt)]

thanks.

Comment 2

[(not reading, please use [e-mail] instead)]

I just checked the following patch in, so that until this bug gets fixed, people
can use the mac debug version.

Index: nsEventQueue.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpcom/threads/nsEventQueue.cpp,v
retrieving revision 3.16
diff -p -r3.16 nsEventQueue.cpp
*** nsEventQueue.cpp    1999/12/20 23:12:18     3.16
--- nsEventQueue.cpp    2000/01/04 00:13:02
*************** NS_IMETHODIMP
*** 191,197 ****
--- 191,200 ----
  nsEventQueueImpl::ProcessPendingEvents()
  {
    PRBool correctThread = PL_IsQueueOnCurrentThread(mEventQueue);
+   /* until dougt fixes #22943, turning this off of the mac */
+ #ifndef XP_MAC
    NS_ASSERTION(correctThread, "attemping to process events on the wrong thread
");
+ #endif /* XP_MAC */

    if (!correctThread)
      return NS_ERROR_FAILURE;
*************** NS_IMETHODIMP
*** 204,210 ****
--- 207,216 ----
  nsEventQueueImpl::EventLoop()
  {
    PRBool correctThread = PL_IsQueueOnCurrentThread(mEventQueue);
+   /* until dougt fixes #22943, turning this off of the mac */
+ #ifndef XP_MAC
    NS_ASSERTION(correctThread, "attemping to process events on the wrong thread
");
+ #endif /* XP_MAC */
    if (!correctThread)
      return NS_ERROR_FAILURE;

Comment 3

[Doug Turner (:dougt)]

fixed

Comment 4

[lchiang]

will mark verified.  I assume you no longer see this in your debug builds, Seth.

Comment 5

[(not reading, please use [e-mail] instead)]

I don't debug on the mac that often.

ducarroz would be able to verify.

Comment 6

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/272f586f3fe8
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/22943: update androidx.lifecycle to 2.4.0