Closed Bug 229450 Opened 21 years ago Closed 21 years ago

JavaScript strict warning: mailWindowOverlay.js line 403: redeclaration of var msgFolder

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: mnyromyr, Assigned: mnyromyr)

Details

Attachments

(2 obsolete files)

JavaScript strict warning: chrome://messenger/content/mailWindowOverlay.js line
403: redeclaration of var msgFolder

This warning is currently hidden by bug 229437, but the problem is there
nonetheless. :)
Attached patch Just renaming the var (obsolete) — Splinter Review
To keep the context visible I just renamed the variable.
(Actually, since JS only knows two scopes (global or function level), the |var|
keyword is superfluous here.)
Attachment #137987 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 137987 [details] [diff] [review]
Just renaming the var

This looks ugly. Would you mind inlining the call instead i.e. not using a
temporary variable?
Attachment #137987 - Flags: review?(neil.parkwaycc.co.uk) → review-
Attachment #137987 - Attachment is obsolete: true
Attachment #138010 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #138010 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #138010 - Flags: superreview?(bienvenu)
Attachment #138010 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 138010 [details] [diff] [review]
Merge both var definitions
[Checked in: Comment 4]


Check in: { 12/28/2003 07:51	neil%parkwaycc.co.uk	1.178 }
Attachment #138010 - Attachment description: Merge both var definitions → Merge both var definitions [Checked in: Comment 4]
Attachment #138010 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 21 years ago
OS: Windows 2000 → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7alpha
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: sspitzer → mnyromyr
Status: REOPENED → NEW
Taking the blame. Sorry for bugspam.
Status: NEW → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: