229503 - can't change auto-detect options in view->character encoding in view source

Status: RESOLVED FIXED

(Toolkit :: View Source, defect, P3)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208

set auto-detect options in source viewer makes source disappear

Reproducible: Always

Steps to Reproduce:
1.Ctrl+U(Page Source).
2.Wait until all the source loads.
3.View->Character Coding->Auto-Detect->click anyone of them.
Actual Results:  
The page source disappears.

Expected Results:  
The page source should not disappear.

Comment 1

[Robert Mohr]

*** Bug 229504 has been marked as a duplicate of this bug. ***

Comment 2

[Robert Mohr]

From bug 229504, this is supposedly present in FB as well.

Comment 3

[Sekundes]

WFM in the latest build of Mozilla now, but not Firefox.
=> Product

Comment 4

[Anders Pedersen]

WFM.

- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040511
Firefox/0.8.0+
- Microsoft Windows 2000 Pro 5.00.2195 SP4

Comment 5

[Sekundes]

Re #4:
The page source no longer disappeared(it's old bug report) but the Auto-detect
option could not be changed via the menu from page source viewer.

I still experienced this bug using Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8a) Gecko/20040513 Firefox/0.8.0+

Comment 6

[Steffen Wilberg]

Confirming using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040610 Firefox/0.8.0+ (Steffen). WFM with Mozilla 1.7 RC2.
-> view source.

The js console shows:
Error: BrowserSetForcedDetector is not defined
Source File: chrome://global/content/charsetOverlay.js
Line: 118

Comment 7

[Blake Ross]

This is obscure, but broken UI sucks in a finished product. Also, the patch
should be really easy. Putting on the 1.0 list for now.

Comment 8

[(not reading, please use [e-mail] instead)]

accepting...working on it.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 153603 [details] [diff] [review]
patch

r=[e-mail]

Comment 11

[(not reading, please use [e-mail] instead)]

fixed on both firefox trunk and firefox aviary 1.0 branch.

note on the trunk, due to #250474, the fix is slightly different:

-  // As with BrowserSetForcedCharacterSet(), call PageLoader.LoadPage()
+  // As with BrowserSetForcedCharacterSet(), call PageLoader.loadPage()

-  PageLoader.LoadPage(PageLoader.currentDescriptor,
pageLoaderIface.DISPLAY_NORMAL);
+  PageLoader.loadPage(PageLoader.currentDescriptor,
pageLoaderIface.DISPLAY_NORMAL);

Comment 12

[Ryan Polk (Quark)]

setting fixed-aviary1.0 for bugfixes checked into branch, sorry for bugspam.