22956 - color picker doesn't immed. go away after color selection

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P4)

Description

[sairuh (rarely reading bugmail)]

after selecting a color from the color picker, the picker should go away.
occurs on mac and linux (unable to test on win due to bug 21160) using
2000010308 bits.

to repro:
1. go to Preferences > Appearance > Color
2.  for any of the four items (text, background, unvisited links, visited
links), click the colored widget to bring up the color picker.
3. select a color from the picker.

expected: color picker panel should go away

result: color picker remains up --need to click somewhere outside of it to make
it go away.

Comment 1

[don]

Move to M15 since this is not a beta 1 requirement.

Comment 2

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.

Comment 3

[don]

Move to M16 for now ...

Comment 4

[Kathleen :Brade]

*** Bug 36487 has been marked as a duplicate of this bug. ***

Comment 5

[don]

Move to M21 target milestone.

Comment 6

[sairuh (rarely reading bugmail)]

any chance of this getting fixed for beta3?

beppe, is there someone on your team who's working on the colorpicker 
(hurricane?) who might be able to fix this?

Comment 7

[rubydoo123]

actually, this is part of an existing bug -- 47704

*** This bug has been marked as a duplicate of 47704 ***

Comment 8

[sairuh (rarely reading bugmail)]

i don't this is related to bug 47704 anymore, as this deals with the colorpicker
in the Colors panel --which differs from the one in the composer pref panel.
however, there might already bug regarding this issue (which still occurs)...
reopening and looking for that other bug if it exists...

Comment 9

[sairuh (rarely reading bugmail)]

would it be possible to *use* the colorpicker used for the composer new page
settings? if so, could we get the change checked in by rtm?

if not, then i'd likely mark this a dup of bug 42894 (which has been futured).

Comment 10

[Matthew T (active 1999-2002)]

This ain't minor, this is tacky. I can imagine the reviews now ... `The color 
picker, like the rest of the suite, is very buggy: it doesn't go away when you 
select a color, and it only offers a limited range of colors with no option to 
add your own'.

This also ain't a Preferences bug, it's an XPToolkit/Widgets bug.

Comment 11

[Peter Trudelle]

I think this is an extremely minor interaction defect, in a very obscure
feature, with an obvious workaround.  I'll be very happy if the product is so
good that reviewers actually use space to mention this problem.  ->future, rtm-

Comment 12

[Stuart Parmenter]

I have fixes for a bunch of color picker bugs sitting in my tree... such as the
clicking on something other than a color giving you a bogus color, js strict
warnings, etc.

the ability to add your own colors should be pretty easliy addable.  aside from
these, the color picker itself does not include the popup, so anyone using the
colorpicker in a popup and is having problems should be focusing on the popup
and not the colorpicker.

Comment 13

[Peter Trudelle]

->pavlov, p4 for whenever

Comment 14

[Stuart Parmenter]

this specific bug isn't mine (as specified in the summary).  The color picker 
itself is not a window.  Closing the window is up to the person who puts the 
color picker in it.  Is this fixed?

Comment 15

[Matthew T (active 1999-2002)]

Nope, not fixed in 2000122204 build, Windows 98. Color picker still doesn't go 
away when you click on a color.

A good solution to this problem would be to make the prefs panels bring up the 
complete color picker window (as used in Composer), rather than that odd menu-
like thing.

Comment 16

[Charles Manske]

I have a bug on using the more capable Composer color picker for all other
color picker needs (39784), but I'm not sure if it's a priority for mozilla0.9/
NS 6.5. Isn't someone working on an XBL improvement?

Comment 17

[Jesse Ruderman]

The Composer panel in prefs uses buttons that bring up the full Composer color 
picker.

Comment 18

[Matthew T (active 1999-2002)]

*** Bug 65087 has been marked as a duplicate of this bug. ***

Comment 19

[sairuh (rarely reading bugmail)]

clearing status as this problem still exists.

Comment 20

[R.K.Aa.]

seems this is fixed? Testing with a current linux CVS the colorpicker goes away
after a color has been selected. WFM.

Comment 21

[sairuh (rarely reading bugmail)]

yep, this now works. tested using 2001.11.19-comm bits on rh7.2, mac 10.1 and winnt.

Comment 22

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/c941b3452748
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/22956: Define "tags" for metrics in the app repository