Closed Bug 22957 Opened 20 years ago Closed 11 years ago
Window() out of ns NNTPNewsgroup List .cpp and ns Msg Compose Service .cpp
Status: NEW → ASSIGNED
Target Milestone: M13
marking m13, accepting.
Target Milestone: M13 → M14
moving this to m14.
Priority: P3 → P2
No user-visible downside is described here, so pushing out to M15.
Target Milestone: M14 → M15
I'm nsIDialogParamBlock in nsNNTPNewsgroupList.cpp (and eventually I'll switch to nsINewsDownloadDialogArgs) now that I understand what I'm doing, I can fix openWindow in nsMsgComposeService and pass arguments without having to parse them from js.
moving to m16.
Target Milestone: M15 → M16
Triage to M17. Please add beta2 keyword if this must make beta2. Please let me know if this must be done by M16 feature freeze.
Target Milestone: M16 → M17
moving to future milestone.
Target Milestone: M17 → Future
QA Contact: ppandit → stephend
sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.
Assignee: sspitzer → nobody
Status: ASSIGNED → NEW
Filter on "Nobody_NScomTLD_20080620"
QA Contact: stephend → backend
Although we still have OpenWindow in nsMsgComposeService.cpp, IMHO that's the right place for it. Additionally, it doesn't use any JS functions. So I think we can stop linking against the js libs. This works for me on Mac. If this doesn't work on other platforms, then we'll just close this bug. Otherwise we'll do this patch, then close this bug.
(In reply to comment #11) > Created an attachment (id=350760) [details] > Don't link against JS libs ... > Additionally, it doesn't use any JS functions. So I think we can stop linking > against the js libs. This works for me on Mac. Also works on Linux.
Comment on attachment 350760 [details] [diff] [review] Don't link against JS libs > $(LIBS_DIR) \ > $(EXTRA_DSO_LIBS) \ >- $(MOZ_JS_LIBS) \ > $(MOZ_UNICHARUTIL_LIBS) \ > $(MOZ_COMPONENT_LIBS) \ > $(NULL) >diff --git a/mailnews/news/build/Makefile.in b/mailnews/news/build/Makefile.in >--- a/mailnews/news/build/Makefile.in >+++ b/mailnews/news/build/Makefile.in >@@ -85,9 +85,8 @@ EXTRA_DSO_LDOPTS = \ > -L$(DIST)/bin \ > -L$(DIST)/lib \ Not part of this bug but this should be $(LIBS_DIR) too, no?
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: Future → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.