Closed Bug 229600 Opened 21 years ago Closed 20 years ago

Installing 2 extensions without restarting re-launches extension-installer for previous installed extensions

Categories

(Toolkit :: Downloads API, defect, P1)

Product:
Toolkit
Component:
Downloads API
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED WORKSFORME
Milestone:
mozilla1.7

People

(Reporter: avbohemen, Assigned: bugs)

Details

(Keywords: regression)

Attachments

(1 file)

How to reproduce this bug - testcase
918 bytes, text/plain
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031227 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031227 Firebird/0.7+

This must be a side-effect of bug 228986

After I installed a second extension without restarting, I was again asked the
questions from the intaller of the first extension: I installed the Popup-ALT
extension, followed by TBE (both from Piro). The extensions both ask if I want
Japanese language and whether the extension should be in my profile or not.
After I installed the TBE (the 2nd extension in a row), I got the questions
again for Popup-ALT, again followed by "the popup-alt extension was installed
correctly".

Reproducible: Always

Steps to Reproduce:
1. Install an extension. Answer the questions asked by the extension-installer,
and click OK to "... installed correctly.
2. Install a second extension. Answer the questions asked by the
extension-installer, and click OK to "... installed correctly.
3. Install a third extension. Answer the questions asked by the
extension-installer, and click OK to "... installed correctly.

Actual Results:  
After clicking OK to "the 2nd extension installed correctly", I got the
questions from the installer of the first extension again. After the 3rd
extension, both the second and the first extension installer were repeated.

Expected Results:  
Run every extension installer only once.
Keywords: regression
Additional info: This only happens on the 0.8-branch, not on the trunk.
Confirming this bug on Win98, official branch build 20031228.
Flags: blocking0.8?
Flags: blocking0.8? → blocking0.8+
zeron: As you're not part of Mozilla Drivers, you should refrain from setting
the blocking+ flag -- that's their call.
Flags: blocking0.8+ → blocking0.8?
alex: afaik drivers aren't driving firebird, so the list is even smaller :)
Alex:  Oops, sorry.  I could have sworn that not too long ago it was called for
users to set + on the 0.8 blocking flags to nominate what should block and the
dev team would look over it.  Perhaps I misunderstood something.  (Maybe I was
thinking of something else?)
zeron: it was blocking0.8?, not blocking0.8+.  All requests for flags (no matter
what they be) are set to ?, not +, by the requester.  Devs later set them to +
or - if they agree/disagree.  See:

http://forums.mozillazine.org/viewtopic.php?t=38467

...for Ben's original announcement on nominating.
Jeff:  Thank you for the explanation.  I apologize for all the bug spam.
Actually this occurs even if you restart the browser, if you have the download
manager set to only remove entries manually and you do not remove the entry for
the .xpi file for the extension.  I have the adblock and ttlo2 extensions .xpi
files saved to disk.  If I install MozillaFirebird Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102 Firebird/0.7+ in an empty
directory and start it with a fresh profile and leave the download manager
privacy option set to remove entries manually, then if I go to file->open and
open the adblock .xpi file and do that install then exit firebird and restart
and then to File -> Open ttlo2.xpi it reruns the adblock install as soon as the
ttlo2 isntall completes.
It also happens when installing 2 themes. 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031226
Firebird/0.7+ (scragz)
I don't see this with a current branch build. (2003/1/13)
I've just seen it on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6)
Gecko/20040114 Firebird/0.7+.
Used drag and drop to install both extensions (Link Toolbar and LinkIt).
I installed them to the program folder, not my profile.

Fixed for me with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040114 Firebird/0.7+
I installed flashblock.xpi and image_zoomer.xpi in a row, clicking on their
respective link : no installer re-launch.
Thanks !
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040115 Firebird/0.7+
(.:MrC:.)

This bug is still present - after installing six extensions in a row I started
getting repeated confirmation popups for extensions like CTC and Next Image.
Sorry for bugspam - it also happened with Live HTTP Headers.
This is marked as OS: Windows 2000 but I am seeing this behavior in the release
build for linux (GTK2+XFT):

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040114 Firebird/0.7+

and my own 2004-01-15 build:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040115 Firebird/0.7+
(.:MrC:.)

I built from the branch.
OS: Windows 2000 → Linux
Can someone with proper priviledge please change the OS on this bug to all?
-> All
OS: Linux → All
I changed it to Linux because no one has confirmed it is still a problem on Windows
In 20031226 build I had it in winXP. 
And a fix was checked in on 1/14.
This problem does not appear to occur every time.  I have an idea that it
depends on which extensions and is also timing sensitive in some way.  The
following fails for me everytime with this:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040114 Firebird/0.7+

build (which is hte latest 0.8 branch windows build available as I write this).

1.  download and save the Adblock extension from this URL:
http://adblock.mozdev.org/adblock-0.5-dev.xpi

2.  download and save the ttlo extension from this URL:
http://downloads.mozdev.org/flibble/ttlo2.xpi

3.  Install firebird into a clean directory.

4.  Use profile manager to create a new profile

5.  Launch firebird using the profile created in step 4.

6. Using the File -> Open File menu, open the file where you saved the adblock
extension in step 1, and run the adblock install selecting default options.

7. Using the FIle -> Open File menu, open the file where you saved the ttlo
extension in step 2, and run the ttlo install selecting default options.

When the ttlo install completes you will get a pop-up saying that adblock is
already installed in your profile.
Definitely something wonky going on.  On my fourth extension I wound up with
about 4 confirmation dialogs.  

Installed TBE
Installed CuteMenus
Installed MozFBRH
Installed PasteIP

Clicked the link for Show Failed URL ... Firebird crashed after a while

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040114 Firebird/0.7+
per ben on IRC
Flags: blocking0.9?
Flags: blocking0.8?
Flags: blocking0.8-
Was Ben's branch-only checkin "Fix a problem with the installer when installing
several extensions in one transaction" for this bug?  (He checked in a few hours
ago, so the change will be in tomorrow's builds.)
Mozilla/5.0 (Windows; U; Windows NT 5.0; ja-JP; rv:1.6) Gecko/20040205 Firebird/0.7+

Not fixed...

Maybe, this problem occurs only when installing xpis from local/network drives.
Not directly from web sites.

I don't understand why this bug was left in the final 0.8 release. :-/ It would
put off a lot of new users attracted by the new installer. Not a smart marketing
move, if you ask me.
This bug will also cause a previously-cancelled extension install to be executed.
I just created a new profile and was reinstalling my extensions by
drag-and-drop, restarting after each one. I accidentally dragged on Pike's
version of SessionSaver, hit cancel and dragged on Rue's version instead. It
installed, then the old version installed as well, followed by a crash. The
crash was probably caused by the extensions, but the fact remains that a
cancelled extension was subsequently installed without my authorisation.
target.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox0.9
Comment on attachment 141812 [details]
How to reproduce this bug - testcase

>I just removed my Firebird and installed Firefox from scratch and when tried to install extensions I had installed with Firebird, Download Manager asks same thing for each extension (starting from AdBlock and going down through the list of all extensions available).
>
>So I installed one extension (AdBlock), then just left download manager open, focused the main window with mozilla extension website and clicked to install new extensions. Then when run and installed with success, Installer asks me whether to install previous extension - and you can't cancel the dialog - some window about Japanese language pops up.
>
>Also when installed some other extensions afterwards, it showed me 1 message for each extensions installed before in pop up - something like 'File downloaded. Installation finished with success' - try to have 7 extensions installed and after adding new one clicking on 7 messages popping out. Really messy and pestiferous....
(In reply to comment #25)
> Mozilla/5.0 (Windows; U; Windows NT 5.0; ja-JP; rv:1.6) Gecko/20040205
Firebird/0.7+
> 
> Not fixed...
> 
> Maybe, this problem occurs only when installing xpis from local/network drives.
> Not directly from web sites.
> 
If I install extensions from file (I saved them to disk before) in Firefox 0.8 I
get all kinds of errors. Installation error codes. Download manager saying that
it's still downloading files when I close firefox. Then if I install other
extension I sometimes get still messages from other extensions I installed. I
saw this on Win XP. This problem seems to be related to this bug 

my fix for 234910 may fix this...
Did the fix for bug 234910 fix this bug?
(In reply to comment #33)
> Did the fix for bug 234910 fix this bug?

It seems to work for me under linux. :-)

BTW what's the reason for having a 2 second delay before install now is enabled??


If I remember the comment that went with it, it is to prevent someone from
rapidly clicking without realizing what they're doing.
Yeh - because potentially extensions could install malicious software (spyware 
etc.) on your computer so its to make sure you read whats about to install and 
if you didn't request it click cancel rather than automatically clicking the 
first button to come to hand. I think it makes sense - its not like two seconds 
is long to wait. Now if it were 5 seconds it would be annoying.
To comment #33 and #34:
Fixed on windows too, using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.7b) Gecko/20040313 Firefox/0.8.0+ (BlueFyre)
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316 Firefox/0.8.0+
(daihard: XFT+GTK2; opt. for P4/SSE-2)

VERIFIED FIXED. I just installed eleven extensions in a row without a single
problem.

All that's needed now is a clearer method to indicate errors (but that's another
bug).
Installing multiple extensions via window.InstallTrigger still causes problems
(unfinished downloads in the Download Manager and lingering xpicleanup.dat
file), but I assume that's a different bug?
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040408 Firefox/0.8.0+
(daihard: XFT+GTK2; opt. for P4/SSE-2)

I installed twenty extensions and one theme in a row without a restart and
without clearing the Download Manager history. The bug described in the summary
did not appear.

I really think this has been fixed ;-)
(In reply to comment #39)
> Installing multiple extensions via window.InstallTrigger still causes problems
> (unfinished downloads in the Download Manager and lingering xpicleanup.dat
> file), but I assume that's a different bug?

I think yes. 

Tested installing with 5 extensions and it's also working with Mozilla/5.0
(Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040412 Firefox/0.8.0+

-> WFM
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → VERIFIED
Flags: blocking0.9?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: