Closed Bug 229684 Opened 20 years ago Closed 20 years ago
application/octet-stream should have better description
In: http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#342 ...we hardcode the description of application/octet-stream to "Binary Executable". This is inaccurate. It would be better to have it described as something like "Binary data or executable" or just "Binary file". (It also seems weird that this would depend on a per-platform basis -- the user's platform surely doesn't in any way affect the type of the file...)
".com" should presumably also be a "binary" extension, while we're at it.
.bin files on mac are typically binhex files, which the OS knows how to handle. On Windows, they are typically actual binary files. Life is hard like that. ;) biesi, do you have time to write up a small patch for this? It'd be good to fix this in 1.7a....
this patch uses "Binary File". also, this patch contains a fix for the following bug: (I didn't feel like doing it in a separate bug, with a separate patch, separate reviews etc) If the OS has info for a type, but prefs contain neither info via type nor via ext, we would get the mimeinfo from extras.
Assignee: file-handling → cbiesinger
Target Milestone: --- → mozilla1.7alpha
Status: NEW → ASSIGNED
Comment on attachment 138138 [details] [diff] [review] patch, also add "com" as extension Looks good. r+sr=bzbarsky I'm not sure whether "Binary data" or "Binary file" is better; I get "Binary file" is fine.
Checking in nsExternalHelperAppService.cpp; /cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <-- nsExternalHelperAppService.cpp new revision: 1.236; previous revision: 1.235 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.