If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

whineatnews.pl doesn't whine about REOPENED bugs

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Email Notifications
RESOLVED FIXED
14 years ago
5 years ago

People

(Reporter: Joseph Heenan, Assigned: Joseph Heenan)

Tracking

unspecified
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322)
Build Identifier: 

whineatnews.pl does not send emails to users who have bugs in the REOPENED 
state, whereas you could expect it to because the state is basically equivalent 
to the NEW state.

Reproducible: Always

Steps to Reproduce:
(Assignee)

Comment 1

14 years ago
Created attachment 138212 [details] [diff] [review]
Patch to make whineatnews.pl send mail about reopened bugs too

Attachment is patch to fix the problem - changes sql in whineatnews to include
reopened bugs, and updated defparams to include text that mentions reopened as
well as new.

Comment 2

14 years ago
Comment on attachment 138212 [details] [diff] [review]
Patch to make whineatnews.pl send mail about reopened bugs too

Kiko, maybe you can take a look at this, both conceptually and code-proof. :-)
Attachment #138212 - Flags: review?(kiko)

Comment 3

14 years ago
Asked Justdave about this and he says it makes sense, so let's have a look at
the code.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 4

14 years ago
Comment on attachment 138212 [details] [diff] [review]
Patch to make whineatnews.pl send mail about reopened bugs too

Looks simple enough.
Attachment #138212 - Flags: review?(kiko) → review+

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+

Comment 5

14 years ago
Let me know if I'm supposed to check this in, though I suppose it would be fine
if Vlad did so too.

Updated

14 years ago
Assignee: preed → joseph

Comment 6

14 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 7

14 years ago
There was a tab in whineatnews.pl; I just fixed that while checking in.

Remember, every time you place a tab in a file containing Bugzilla code, A
KITTEN IS MURDERED. If you won't do it for us, at least think of the kittens.

Comment 8

14 years ago
Me slaps kiko with a murdered kitten and tells him not to get sensitive and
sentimental with our patch writers. ;-)
(Assignee)

Comment 9

14 years ago
Thanks Kiko. Apologies for the tab, it was entirely accidental, we don't allow 
them here either :-) (Was there some sort of test suite or checker I should 
have run that would have picked it up?)

Comment 10

14 years ago
Yeah, you can call runtests.sh (you need Test::More and something else IIRC) and
it will runs a number of tests -- one of them checks for tabs. Luckily, our
tinderboxes are out so I didn't cause a red tree :-)
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Comment 11

14 years ago
A note about this change should probably be added to the release notes to
suggest that people upgrading probably want to update their 'whinemail'
parameter to mention reopened bugs.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.