User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322) Build Identifier: whineatnews.pl does not send emails to users who have bugs in the REOPENED state, whereas you could expect it to because the state is basically equivalent to the NEW state. Reproducible: Always Steps to Reproduce:
Created attachment 138212 [details] [diff] [review] Patch to make whineatnews.pl send mail about reopened bugs too Attachment is patch to fix the problem - changes sql in whineatnews to include reopened bugs, and updated defparams to include text that mentions reopened as well as new.
Comment on attachment 138212 [details] [diff] [review] Patch to make whineatnews.pl send mail about reopened bugs too Kiko, maybe you can take a look at this, both conceptually and code-proof. :-)
Asked Justdave about this and he says it makes sense, so let's have a look at the code.
Comment on attachment 138212 [details] [diff] [review] Patch to make whineatnews.pl send mail about reopened bugs too Looks simple enough.
Let me know if I'm supposed to check this in, though I suppose it would be fine if Vlad did so too.
There was a tab in whineatnews.pl; I just fixed that while checking in. Remember, every time you place a tab in a file containing Bugzilla code, A KITTEN IS MURDERED. If you won't do it for us, at least think of the kittens.
Me slaps kiko with a murdered kitten and tells him not to get sensitive and sentimental with our patch writers. ;-)
Thanks Kiko. Apologies for the tab, it was entirely accidental, we don't allow them here either :-) (Was there some sort of test suite or checker I should have run that would have picked it up?)
Yeah, you can call runtests.sh (you need Test::More and something else IIRC) and it will runs a number of tests -- one of them checks for tabs. Luckily, our tinderboxes are out so I didn't cause a red tree :-)
A note about this change should probably be added to the release notes to suggest that people upgrading probably want to update their 'whinemail' parameter to mention reopened bugs.