Closed
Bug 229812
Opened 21 years ago
Closed 20 years ago
CSS Errors in themes
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(2 files, 3 obsolete files)
6.66 KB,
patch
|
neil
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
6.66 KB,
patch
|
neil
:
review+
neil
:
review+
|
Details | Diff | Splinter Review |
CSSParse.exe in debug dist/bin shows several errors in css files used in themes. Patch coming up. May fix bug 161789.
Assignee | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
+ padding: 4px 0px 0px 0px; This can be written shorter as + padding: 4px 0 0;
Attachment #138221 -
Flags: superreview?(dbaron)
Attachment #138221 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 3•21 years ago
|
||
Comment on attachment 138221 [details] [diff] [review] patch v0 >Index: themes/classic/global/mac/xulscrollbars.css >=================================================================== >RCS file: /cvsroot/mozilla/themes/classic/global/mac/xulscrollbars.css,v >retrieving revision 1.4 >diff -u -p -u -r1.4 xulscrollbars.css >--- themes/classic/global/mac/xulscrollbars.css 21 Nov 2003 10:45:24 -0000 1.4 >+++ themes/classic/global/mac/xulscrollbars.css 31 Dec 2003 20:07:22 -0000 >@@ -47,7 +47,7 @@ slider { > slider[orient="vertical"] { > -moz-appearance: scrollbartrack-vertical; > width: 16px; >- height: none; >+ height: 0; > background-image: url("chrome://global/skin/scrollbar/slider-vrt.gif"); > } > >@@ -158,7 +158,7 @@ scrollbar[orient="vertical"] > scrollbar > html|div slider[orient="vertical"] { > -moz-appearance: scrollbartrack-vertical; > width: 16px; >- height: none; >+ height: 0; > background-image: url("chrome://global/skin/scrollbar/slider-vrt.gif"); > } > I note that the modern theme doesn't try to reset the height, so if this rule gets ignored it probably doesn't matter, and that's without even taking the effect of -moz-appearance into account. >Index: themes/modern/communicator/related/related.css >=================================================================== >RCS file: /cvsroot/mozilla/themes/modern/communicator/related/related.css,v >retrieving revision 1.8 >diff -u -p -u -r1.8 related.css >--- themes/modern/communicator/related/related.css 19 Dec 2001 11:51:14 -0000 1.8 >+++ themes/modern/communicator/related/related.css 31 Dec 2003 20:07:23 -0000 >@@ -114,6 +114,6 @@ treeitem[selected="true"] > treerow.rela > } > > .tree-cell-twisty { >- visibility: collapsed; >+ visibility: hidden; > } > This code is so old predates outliner... if you really feel a need to touch it just remove the whole rule as per classic. >Index: themes/modern/editor/EdImageMapPage.css >=================================================================== >RCS file: /cvsroot/mozilla/themes/modern/editor/EdImageMapPage.css,v >retrieving revision 1.6 >diff -u -p -u -r1.6 EdImageMapPage.css >--- themes/modern/editor/EdImageMapPage.css 19 Dec 2001 11:51:39 -0000 1.6 >+++ themes/modern/editor/EdImageMapPage.css 31 Dec 2003 20:07:23 -0000 >@@ -99,7 +99,7 @@ html { > left: -5px; > z-index: 10000; > width: 1px; >- height: -5px; >+ height: 5px; > } > > #bgDiv { I think this was probably supposed to be top: -5px; and height: 1px;
Attachment #138221 -
Flags: review?(neil.parkwaycc.co.uk) → review-
Attachment #138221 -
Flags: superreview?(dbaron)
Assignee | ||
Comment 4•21 years ago
|
||
updated version addressing Neil's comments.
Attachment #138221 -
Attachment is obsolete: true
Comment 5•20 years ago
|
||
Bob: Is your patch ready for review? I just tested it and ist still applies (except dialogOverlay.css was removed from the tree in the meantime).
Assignee | ||
Comment 6•20 years ago
|
||
Updated patch v2.
Attachment #139089 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #144172 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 7•20 years ago
|
||
Comment on attachment 144172 [details] [diff] [review] patch v2 >-#marquee {position:absolute; top:1px; left:-5px; height:-5px; width:1px; border: 1 dashed #0000ff; z-index:10000; visibility: hidden;} >-#bgDiv {position:absolute; top:0px; left:0px; width:1; background:url("chrome://editor/skin/images/Map_checker.gif"); background-color: white; cursor: inherit;} >+#marquee {position:absolute; top:1px; left:-5px; height:5px; width:1px; border: 1px dashed #0000ff; z-index:10000; visibility: hidden;} >+#bgDiv {position:absolute; top:0px; left:0px; width:1px; background:url("chrome://editor/skin/images/Map_checker.gif"); background-color: white; cursor: inherit;} Just fix these #marquee fixes to match those quoted below. >RCS file: /cvsroot/mozilla/themes/classic/global/win/Attic/dialogOverlay.css,v Whoops ;-) ^^^ > #marquee { > visibility: hidden; > position: absolute; >- top: 1px; >+ top: -5px; > left: -5px; > z-index: 10000; > width: 1px; >- height: -5px; >+ height: 1px; > }
Attachment #144172 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 8•20 years ago
|
||
Updated•20 years ago
|
Attachment #144284 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Attachment #144284 -
Flags: superreview?(alecf)
Assignee | ||
Updated•20 years ago
|
Attachment #144172 -
Attachment is obsolete: true
Comment 9•20 years ago
|
||
Comment on attachment 144284 [details] [diff] [review] v3 shouldn't that be 4px 0 0 0 ; ? Otherwise the last 0 might be overridden by another style rule... sr=alecf with that corrected.
Attachment #144284 -
Flags: superreview?(alecf) → superreview+
Comment 10•20 years ago
|
||
No, "4px 0 0;" mean "4px (top) 0 (left and right) 0 (bottom)".
Assignee | ||
Comment 11•20 years ago
|
||
Attachment #144342 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 12•20 years ago
|
||
Comment on attachment 144342 [details] [diff] [review] patch v4 with the change to padding: 4px 0 0 0; This should have been checked in ages ago, alecf's nit didn't warrant a rereview, let alone two :-P
Attachment #144342 -
Flags: review?(neil.parkwaycc.co.uk)
Attachment #144342 -
Flags: review+
Comment 13•20 years ago
|
||
This was checked in in May. Marking FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•