229813 - CSS Errors in Firefox skins

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

CSSParse.exe in debug dist/bin shows several errors in css files used in
skins. Patch coming up.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch v0

Comment 2

[Mike Connor [:mconnor]]

-> mac theme owner

Comment 3

[Kevin Gerich]

Thanks Bob. Do these errors show up in the console of the debug build? If not,
do you by any chance know how to verify this on a Mac build, where CSSParse.exe
doesn't exist?

Comment 4

[Bob Clary [:bc] (inactive)]

Kevin,

I don't think these errors show up in normal operation but might show in the
javascript console if you were to visit a web page that included these
stylesheets in a debug build.

FYI, here are the error messages I see. The attached patch looks more
complicated that it really is. It includes fixes for the mangling of the file
format. It appears that the files' line endings were incorrectly checked in
resulting in a embedded carriage returns etc.

CSS Error
(file:///c:/work/mozilla_source/trunk/mozilla/toolkit/skin/mac/menulist.css
:127.16): Unknown property '-mox-box-flex'.  Declaration dropped.
CSS Error
(file:///c:/work/mozilla_source/trunk/mozilla/toolkit/skin/mac/progressmeter.css
:80.8): Unknown property 'align'.  Declaration dropped.
CSS Error
(file:///c:/work/mozilla_source/trunk/mozilla/toolkit/skin/mac/wizard.css
:32.17): Expected end of value for property but found '20'.  Error in parsing
value for property 'margin'.  Declaration dropped.
CSS Error
(file:///c:/work/mozilla_source/trunk/mozilla/toolkit/skin/mac/wizard.css
:45.18): Expected end of value for property but found '10'.  Error in parsing
value for property 'padding'.  Declaration dropped.

Comment 5

[Anne (:annevk)]

Still a problem?

Comment 6

[Kevin Gerich]

I bet the errors are still there. I'll retest and make a patch against the trunk

Comment 7

[Bob Clary [:bc] (inactive)]

Thanks Kevin.

Comment 8

[Kevin Gerich]

Attachment: tweak to wizard.css

I only found one of the errors that you listed, Bob. The others must have been
fixed in the sprint to 1.0. Let me know if you find any others

Comment 9

[:Gavin Sharp [email: [e-mail]]]

*** Bug 270549 has been marked as a duplicate of this bug. ***