Closed Bug 229816 Opened 19 years ago Closed 19 years ago
Hide "For Internet Explorer Users" item for platforms without IE
Based on Jeff Walden's MozDev Bug 5335 filed in Bugzilla. This bug should be in Bugzilla since it can't be fixed with the normal extension UI. Firebird Help is on the trunk anyway, so this is the better place. Patch coming up soon. His report is below: It would be a nice touch to show users of platforms that don't have IE that we aren't completely Windows-centric. I think it would require the preprocessor with some sort of thing like so around the relevant XUL code: #ifdef XP_MACOSX ...XUL overlay code for that menu entry... #endif Then we'd need to add a * at the front of the overlay's line in the correct jar.mn. If this requires the preprocessor, I think it'll need to wait until Help is integrated into the tree so we can still make XPIs the old-fashioned way (copy and zip). If it's not worth the hassle, tho, I can understand.
Comment on attachment 138230 [details] [diff] [review] Patch I guess ben would be the best person for review ?
Removing the item from the Help menu on Linux sounds like a goot idea, but hiding the TOC entries could be problematic. This way of using platform ifdefs in locale files are not good for translators because it forces L10n teams to have different language packs for each of the platforms. See bug #176041 for examples. L10n teams that use the jar files from Linux builds when they translate, will end up not having the IE TOC entries in their language packs. This will not cripple the browser like a incomplete .dtd file could, but it would still be unfortunate.
Comment on attachment 138230 [details] [diff] [review] Patch Hasse: good catch! yeah, we should probably have the content there but not the Menu Item. I'll post a new patch soon.
Microsoft released versions of Internet Explorer for Solaris and HP-UX . You might want to ignore these or you might not.
Component: General → Help
QA Contact: mconnor → firefox.help
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.