If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Turn off non-virtual destructor warnings

RESOLVED FIXED

Status

SeaMonkey
Build Config
--
trivial
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
With the compiler flags we use, gcc issues a warning in many cases if you define
a class that has virtual functions but does not have a virtual destructor.  This
causes bogus warnings (quite a few, with another patch I'm working on), and in
general isn't useful for most of the code in our tree.

Some classes probably unnecessarily define virtual destructors just to quiet the
compiler, too... a virtual destructor is only needed if your object could be
deleted through a base class pointer.
(Assignee)

Comment 1

14 years ago
Created attachment 138263 [details] [diff] [review]
patch
(Assignee)

Updated

14 years ago
Attachment #138263 - Flags: review?(dbaron)
Comment on attachment 138263 [details] [diff] [review]
patch

r=dbaron.  See also the discussion in bug 113192.
Attachment #138263 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

14 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
This patch got rid of 15 "'class xxx' has virtual functions but non-virtual
destructor" 'Blamed Build Warnings; Linux brad Clobber' :-)
Blocks: 187528
Severity: normal → trivial
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.