229969 - Fix 'Warning: "/*" within comment' from 'Blamed Build Warnings; Linux brad Clobber'

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Serge Gautherie (:sgautherie)]

Note that this (beos) is bogus too:
{
5.	uriloader/exthandler/beos/nsOSHelperAppService.cpp:933 (See build log excerpt)
	Warning: "/*" within comment

931 
}

The actual (unix) warning is:
{
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/uriloader/exthandler/unix/nsOSHelperAppService.cpp:933:10:
warning: "/*" within comment
}

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <nsOSHelperAppService.cpp> (*2)

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 138336 [details] [diff] [review]
(Av1) <nsOSHelperAppService.cpp> (*2)


I have no compiler: Could you compile/test/review it ? Thanks.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

in my opinion, this build warning is not worth making the comment less readable.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

if you really want to fix this, please use C++ style comments:

// text/*

Comment 5

[Boris Zbarsky [:bzbarsky]]

I agree with comment 3.  If you absolutely must have this, go with comment 4,
but I would prefer that this code simply didn't get changed (I saw the warning
when I wrote the code, and the clarity of the comment is the single most
important thing here; the warning is a matter of sublime unconcern).

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) <nsOSHelperAppService.cpp> (*2)

Av1, with comment 4 suggestion(s).

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 138341 [details] [diff] [review]
(Av1b) <nsOSHelperAppService.cpp> (*2)


I have no compiler: Could you compile/test/review it ? Thanks.


Re comment 5:

I don't have an immediate need for this fix: I'm only trying to reduce the
warning number.

I'd like to have this one fixed too;
but you may "R.WontFix" as well...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138341 [details] [diff] [review]
(Av1b) <nsOSHelperAppService.cpp> (*2)

Yeah, that's not too bad, I guess.  Damn moronic compilers.  :(

r+sr=bzbarsky; I also have no way to compile this, but it looks ok.  biesi,
would you mind landing this?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

I'll do it probably tomorrow

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

compiled fine on linux with gcc-Version 3.3.3 20031206 (prerelease) (Debian)

patch checked in