Fix 'Warning: "/*" within comment' from 'Blamed Build Warnings; Linux brad Clobber'

RESOLVED FIXED in mozilla1.7alpha

Status

Core Graveyard
File Handling
--
trivial
RESOLVED FIXED
14 years ago
2 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.7alpha

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

14 years ago
Note that this (beos) is bogus too:
{
5.	uriloader/exthandler/beos/nsOSHelperAppService.cpp:933 (See build log excerpt)
	Warning: "/*" within comment

931 
}

The actual (unix) warning is:
{
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/uriloader/exthandler/unix/nsOSHelperAppService.cpp:933:10:
warning: "/*" within comment
}
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
(Assignee)

Comment 1

14 years ago
Created attachment 138336 [details] [diff] [review]
(Av1) <nsOSHelperAppService.cpp> (*2)
(Assignee)

Comment 2

14 years ago
Comment on attachment 138336 [details] [diff] [review]
(Av1) <nsOSHelperAppService.cpp> (*2)


I have no compiler: Could you compile/test/review it ? Thanks.
Attachment #138336 - Flags: review?(bz-vacation)
in my opinion, this build warning is not worth making the comment less readable.

Component: Browser-General → File Handling
if you really want to fix this, please use C++ style comments:

// text/*
I agree with comment 3.  If you absolutely must have this, go with comment 4,
but I would prefer that this code simply didn't get changed (I saw the warning
when I wrote the code, and the clarity of the comment is the single most
important thing here; the warning is a matter of sublime unconcern).
(Assignee)

Comment 6

14 years ago
Created attachment 138341 [details] [diff] [review]
(Av1b) <nsOSHelperAppService.cpp> (*2)

Av1, with comment 4 suggestion(s).
(Assignee)

Updated

14 years ago
Attachment #138336 - Attachment is obsolete: true
Attachment #138336 - Flags: review?(bz-vacation)
(Assignee)

Comment 7

14 years ago
Comment on attachment 138341 [details] [diff] [review]
(Av1b) <nsOSHelperAppService.cpp> (*2)


I have no compiler: Could you compile/test/review it ? Thanks.


Re comment 5:

I don't have an immediate need for this fix: I'm only trying to reduce the
warning number.

I'd like to have this one fixed too;
but you may "R.WontFix" as well...
Attachment #138341 - Flags: review?(bz-vacation)
Comment on attachment 138341 [details] [diff] [review]
(Av1b) <nsOSHelperAppService.cpp> (*2)

Yeah, that's not too bad, I guess.  Damn moronic compilers.  :(

r+sr=bzbarsky; I also have no way to compile this, but it looks ok.  biesi,
would you mind landing this?
Attachment #138341 - Flags: superreview+
Attachment #138341 - Flags: review?(bz-vacation)
Attachment #138341 - Flags: review+
I'll do it probably tomorrow
compiled fine on linux with gcc-Version 3.3.3 20031206 (prerelease) (Debian)

patch checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.