230173 - Mozilla use 15 point size font for characters with style {font-size:14px;}

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Ervin Yan]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20031229
Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20031229

Mozilla use 15 point size font for characters with style {font-size:14px;}

for example, visit webpage http://news.sina.com.cn

you will see some lines are wrapped. that is because mozilla use 15 point size
font for the Chinese characters with style {font-size:14px;}

Reproducible: Always

Steps to Reproduce:
1.
2.
3.



Expected Results:  
should use 14 point size font for style {font-size:14px;}

Comment 1

[Ervin Yan]

Attachment: use float type for mPointSize

If use PRUint16 type for mPointSize, for 14px style characters, mPointSize
became 11, while convert back to the true font size, it become 15 point size.

but if use float type for mPointSize, for 14px style characters, mPointSize
became 10.5, and remain 14 point size when convert back to the true font size.

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 138463 [details] [diff] [review]
use float type for mPointSize

r=blizzard

This seems pretty reasonable.

Comment 3

[Ervin Yan]

blizzard: could you also give sr? 

Comment 4

[Louie Zhao]

patch checked in.

Comment 5

[Yusuf Goolamabbas]

Viewing this site with the following font settings
Sans-Serif: Verdana: 13 point
Monospace:  LucidaTypewriter 12 point

on a clobber build of MozillaFirebird on Redhat 9 with GTK2

http://forums.mozillazine.org/viewforum.php?f=32

I see a difference in rendering in the hyperlink of the username in the "Last
post" column. It seems much smaller than before

This also shows up in the Slashdot boxes (on the right hand side) which
aggregate RSS feeds from other sites. 

If I revert the changes as suggested by bonsai, then the rendering occurs as before

Comment 6

[Christopher Blizzard (:blizzard)]

I suspect this is going to result in some different rendering.  Whether or not
it's also incorrect is another issue.

Comment 7

[Yusuf Goolamabbas]

tor on irc said that post-checkin he felt the fonts bigger, I feel the opposite
it maybe that whilst tor mentions he has a minimum font size, my setting for
minimum font size is "None"

Comment 8

[Ali Ebrahim]

Using an 2004-01-14 XFT/GTK2 build, I'm seeing smaller font rendering as
compared to an 2004-01-08 XFT/GTK2 build. I'm seeing this not only on the site
that Yusuf mentioned, but on pretty much any site (including cnn.com, mozilla.org).

The fonts just appear generally smaller across the board. I tested by opening
the above two copies of Firebird using different profiles and browsing the same
websites. When switching between windows, the 2003-01-14 build had obviously
smaller fonts.

I don't know if this is corrent or incorrect rendering, but this is what I'm
seeing. FWIW, I'm using Fedora Core 1. Maybe we should reopen this to examine
carefully what's going on.

Comment 9

[Brian Ryner (not reading)]

I think this increased pageload time a bit for xft:

http://axolotl.mozilla.org/graph/query.cgi?testname=pageload&tbox=redwood&autoscale=1&days=7&avg=1&showpoint=2004:01:15:03:07:23,993

shows a pageload spike about the time this went in that isn't present on any
non-xft tinderbox.

Comment 10

[Hixie (not reading bugmail)]

See also bug 197037 comment 29: Assuming that using pixels instead of points
would let us go back to integer maths, that should speed this up too, right?

Comment 11

[Ervin Yan]

I think it is OK to add the following settings in unix.js, 

pref("font.min-size.variable.x-western", 10);
pref("font.min-size.fixed.x-western", 10);

so that Mozilla show English characters OK for small font size.