230396 - cannot create folder in "Bookmarks Toolbar" using context menu

Status: VERIFIED FIXED

Description

[Ahmet A. Akin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20040102 Firebird/0.7+

i cannot create a new bookmark folder by using right click on bookmark toolbar
and choosing "new folder"

Reproducible: Always

Steps to Reproduce:
1. right click on empty area on bookmark toolbar
2. choose "new folder"
3.

Actual Results:  
nothing happens

Expected Results:  
new folder dialog should appear

Comment 1

[José Jeria]

Confirming with 0.8 branch build 20040102, Win XP.

Comment 2

[Mike Connor [:mconnor]]

has this ever worked?  I don't have older nightlies to test, but unless someone
can definitely say it has been working at some point, its not really a regression.

Comment 3

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040107 Firebird/0.7+
(daihard; XFT+GTK2; optimized for P4/SSE-2)

Nothing happens - I don't even get a dialog.

Comment 4

[Ahmet A. Akin]

yes i actually used it several times.

Comment 5

[Bradley Chapman (not reading bugmail, still gone but not forever)]

DO you remember which build it worked on?

Comment 6

[Gregor Larson]

Created attachment 138708 [details] [diff] [review]
Proposed fix for bookmarks menu

This patch appears to fix the problem.
The add was failing because hidePopup was being called on an object
without that method (the new folder dialog).

I'm not really sure this is the correct fix. Someone with more
expertise on this code should look at this.

Comment 7

[Ahmet A. Akin]

ok. for example in
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031203
Firebird/0.7+
works well.

Comment 8

[Pierre Chanial]

I refactored the patch, but the idea was correct.
marking fixed (trunk and branch)

Comment 9

[Jeff Walden [:Waldo]]

> marking fixed

??  or was it not *the bug* that you were talking about being fixed?

Comment 10

[Pierre Chanial]

oops, really marking fixed.

Comment 11

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Yup, definitely fixed.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040110 Firebird/0.8.0+
(daihard: XFT+GTK2; optimized for P4/SSE-2)

Comment 12

[Mike Connor [:mconnor]]

v.

Comment 13

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Removing self from CC list.

Comment 14

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change