230439 - Remove anonymous nodeinfomanager and other cleanup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Peter Van der Beken [:peterv]]

I'm working on doing away with nsINodeInfoManager and here's a first step,
removing the anonymous nodeinfomanager. This involves one change in editor code
to ensure a document is passed when creating a FragmentContentSink (not having a
document at that point is already an error according to the editor code, I've
just made the code ensure it at that point). Patches coming.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Kill anonymous nodeinfomanager

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Share CreateElement code

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 138654 [details] [diff] [review]
Kill anonymous nodeinfomanager

- In NS_NewDocumentFragment():

 {
   NS_ENSURE_ARG_POINTER(aInstancePtrResult);

+  nsINodeInfoManager *nimgr = aOwnerDocument->GetNodeInfoManager();

I'd rather see us check that aOwnerDocument is non-null here than wasting code
on checking that aInstancePtrResult is non-null.

sr=jst

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 138655 [details] [diff] [review]
Share CreateElement code

Nice!

sr=jst

Comment 5

[Peter Van der Beken [:peterv]]

I'll do the remaining work in bug 236408.