Closed Bug 230456 Opened 21 years ago Closed 21 years ago

potential invalid memory access [@nsFontMetricsGTK::TryNodes]

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: darin.moz, Assigned: darin.moz)

Details

(Keywords: crash)

Crash Data

Attachments

(2 files, 1 obsolete file)

potential invalid memory access [@nsFontMetricsGTK::TryNodes]

the following code is invalid:

  const char *FFREName = PromiseFlatCString(aFFREName).get();
  nsCStringKey key(FFREName);

FFREName could point to junk once key is constructed.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
Attached patch v1 patch (obsolete) — Splinter Review
Attached patch v1.1 patchSplinter Review
slightly better version.
Attachment #138672 - Attachment is obsolete: true
Attachment #138673 - Flags: review?(bryner)
Attachment #138673 - Flags: review?(bryner) → review+
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Severity: normal → critical
Reopeing for Xlib port...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Suffering is all mine...
Assignee: darin → Roland.Mainz
Status: REOPENED → NEW
Status: NEW → ASSIGNED
Attachment #140389 - Flags: review?(bryner)
didn't dbaron fix this already?  (i.e., last week sometime)
Darin Fisher wrote:
> didn't dbaron fix this already?  (i.e., last week sometime)

Per
http://bonsai.mozilla.org/cvsquery.cgi?branch=HEAD&file=mozilla/gfx/&date=month
- no.

The patch was made from yesterdays trunk CVS, I simply copied the code from GTK+
to Xlib land and tested the Xprint module.
please don't reopen and reassign fixed bugs because you want to fix a different bug.
Assignee: Roland.Mainz → darin
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
David Baron wrote:
> please don't reopen and reassign fixed bugs because you want to fix a 
> different bug.

This is not a different bug. This is the same bug. The GTK+ and Xlib code is
nearly identical in this area.
I don't mind you attaching the patch to this bug.  However, the bug report as
described, is fixed, so it shouldn't be reopened, and it should remain assigned
to the person who actually did the work of fixing it.
Attachment #140389 - Flags: review?(bryner) → review+
Product: Core → Core Graveyard
Crash Signature: [@nsFontMetricsGTK::TryNodes]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: