230621 - localeVersion is not changed yet for 1.6 final (i.e. on 1.6 branch)

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[matsuba]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7a) Gecko/20040110 Firebird/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.7a) Gecko/20040110 Firebird/0.8.0+

I checked all localeVersion of contents.rdf in US.jar and en-{US,unix,win,mac}.jar.
but localeVersion is not changed yet for 1.6 final.

http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2004-01-09-13-1.6/mozilla-i686-pc-linux-gnu.tar.gz

,

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Robert Kaiser]

Yes, this is true. And normally, we should have little enough string changes
from beta to final that we can use the same language packs and don't need an
different localeVersion.

This time, this couldn't be enforced too well, so I (and other localizers) also
believe we'll need this change.

It's as simple as removing the "b" from the version strings found in
mozilla/source/config/chrome-versions.sh
on the Mozilla 1.6 branch.

drivers:
I'd be willing to check in the change if you need some person to do it.
I believe we should really do this because our 1.6 builds would break if people
install a 1.6 Beta language pack, and this wouldn't feel to good for us...

Comment 2

[Giacomo Magnini]

FWIW, I do agree with Kairo. The update 1.6b ->1.6 led to around 20 string
changes. It's true that most of them are just "refinements" of sentences for
clarity, but IIRC some were prefs changes. It will take just another spin for
the builds and saves us (you?) lots of troubles in localized builds...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just changed it.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Out of curiosity, which changes were taken that caused string changes?

Comment 5

[matsuba]

OK. I Checked in the change between 1.6b and 1.6 again.
If people install a 1.6 Beta language pack, 
it will operate without a problem.
I do agree with Kairo and Giacomo Magnini.
Thanks.

Changed:

US/communicator-region/region.properties
US/navigator-region/region.properties
US/global-region/region.dtd
en-US/help/welcome_help.xhtml
en-US/help/help-toc.rdf
en-US/help/mail_help.xhtml
en-US/messenger/messengercompose/composeMsgs.properties
en-US/navigator/navigator.dtd

Comment 6

[Robert Kaiser]

dbaron:
normally, all the bugs that changed L10n strings between beta and final should
have the late-l10n keyword set. I'm not sure though if that was already the case
this time, as the keyword is very new.

Anyways, thanks for the change.

Comment 7

[Giacomo Magnini]

The late-l10n was late :) for the changes went into 1.6 after 1.6b.
I don't have all of the changes handy, but I still remember chatzilla changes,
and the removing of the netscape search engine. A few wording changes in the
account manager strings occurred too, IIRC. Downloading a 1.6b build and the
relative italian glossay so I can be more precise.

Comment 8

[Giacomo Magnini]

These are the files showing changed strings:
composeMsgs.properties
region.properties
region.dtd (in both communicator-region and navigator-region) 
The other changes were only made to binary files.

Comment 9

[Robert Kaiser]

yes, the packs without the message compose change would be misleading for
people, as the functionality if clicking the "OK" button was changed significantly.
I thought the removing of Netscape Search was also post-beta?

Comment 10

[Giacomo Magnini]

Yep, it was post beta and went it because the search engine is no more...
It was the first bug sporting the new late-l10n keyword, IIRC.

Comment 11

[matsuba]

http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2004-01-13-10-1.6/mozilla-i686-pc-linux-gnu.tar.gz

It has checked that localeVersion was changed. Thanks.

US.jar
en-{US,unix,win,mac}.jar
chatzilla.jar
inspector.jar
venkman.jar

Comment 12

[Robert Kaiser]

matsuba:
If you're verifying that a bug has been fixed, it's usually good to mark it
verfied as well.

Comment 13

[matsuba]

I'm sorry. And I appreciate that you changed status.