Closed Bug 230649 Opened 21 years ago Closed 21 years ago

nsIPref removal in Mail Window Front End

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: sspitzer)

References

Details

Attachments

(5 files)

There appear to be just two JS users of nsIPref in mail window front end code.
Attached patch Proposed patchSplinter Review
I've no idea why the commented out code was trying to use the default branch...
Attachment #138823 - Flags: review?(caillon)
Summary: nsIPref removal → nsIPref removal in Mail Window Front End
Comment on attachment 138823 [details] [diff] [review]
Proposed patch

The only thing I don't like is the fact that you are placing a singular item in
a variable name which is plural.  I'd rather you use |gPrefBranch| than
|gPrefs|.  r=caillon if you make that change (yes I realize that more lines
will need to change, but I think it will make the code make more sense).
Attachment #138823 - Flags: superreview?(bienvenu)
Attachment #138823 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 139144 [details] [diff] [review]
Remove gPrefs and use existing pref variable

OK, so this version removes gPrefs because we already have the prefs in the
pref variable.
Attachment #139144 - Flags: superreview?(bienvenu)
Attachment #139144 - Flags: review?(caillon)
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch

OK, this version should make everyone happy :-)
Attachment #139156 - Flags: superreview?(bienvenu)
Attachment #139156 - Flags: review?(caillon)
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch

Better. thanks.
Attachment #139156 - Flags: review?(caillon) → review+
Attachment #139144 - Flags: superreview?(bienvenu)
Attachment #139144 - Flags: review?(caillon)
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch

sr=bienvenu, but I suspect we need to make the matching changes in thunderbird.
Attachment #139156 - Flags: superreview?(bienvenu) → superreview+
Fix checked in to SeaMonkey.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attached patch Untested TB portSplinter Review
Attachment #139196 - Flags: review?(bienvenu)
Attachment #139196 - Flags: review?(bienvenu) → review+
tbird patch checked in as well.
I missed this out last time because it caused a conflict with another patch :-[
Attachment #139731 - Flags: superreview+
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: