User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031114 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031114 there are 2 mistakes in armenian ( armscii8 ) codepage: 1. 'armew' (hex = "A2") corresponds to U0587. mozilla displays U00A7. 2. 'armcomma' (hex = "AB") corresponds to U002C. mozilla displays U0587. I am attaching a test file that demonstrates this bug. the test file was generated using 'table 2' from http://www.freenet.am/armscii/armcs-006.html Reproducible: Always Steps to Reproduce: look at the attached file
15 years ago
Assignee: general → smontagu
Component: Browser-General → Internationalization
QA Contact: general → amyy
Created attachment 138992 [details] DHTML test file This testpage shows 4 errors. I'll correct the conversion tables from the sources at http://www.freenet.am/armscii
this bug is still present in Mozilla 1.7
Summary: 2 errors in armenian (armscii8) character coding converter → 4 errors in armenian (armscii8) character coding converter
Hello Mr. Montagu, the DHTML test file you attached is not correct, it represents mapping from ARMSCII-8A to UTF-8, what we need is the mapping from ARMSCII-8 to UTF-8. IMHO you took the $4 entries from http://www.freenet.am/armscii/xref.txt. Please see the description under http://www.freenet.am/armscii/ Best regards -- Vahe Khachikyan ---
I don't understand comment 4. The codepoints in the test page correspond to $3 in http://www.freenet.am/armscii/xref.txt: e.g. ARMENIAN CAPITAL LETTER AYB is 0xB3, not 0x80.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Created attachment 153726 [details] ARMSCII-8 Mapping table This mapping table is based on http://www.freenet.am/armscii/xref.txt
Created attachment 153727 [details] ARMSCII-8 Mapping table This mapping table is based on http://www.freenet.am/armscii/xref.txt
Attachment #153727 - Attachment is obsolete: true
Created attachment 153729 [details] [diff] [review] patch The patch is generated by umaptable.c from the mapping file in the previous attachment.
Attachment #153729 - Flags: review?(jshin)
Hello Mr. Montagu, thank you for the patch I'll try to test this today evening. I would like to test the change against 1.7. Is it enought to apply the patch to this two files armscii.uf,armscii.ut or should I use also an updated umaptable.c? About Mapping table: Comment 4 was a failure. The only thing I found in test files you attached is the fact that you call the glyph under 0xAA(ARMSCII) U+055D "ARMENIAN COMMA" but it's name is ARMENIAN SEPARATOR. Not important at all just for sanity :-) Best regards -- Vahe Khachikyan ---
(In reply to comment #9) > Is it enought to apply the patch to this two files > armscii.uf,armscii.ut or should I use also an updated umaptable.c? armscii.uf and armscii.ut are all you need. > The only thing I found in test > files you attached is the fact that you call the > glyph under 0xAA(ARMSCII) U+055D "ARMENIAN COMMA" but it's name is ARMENIAN > SEPARATOR. For what it's worth, I used the names from http://www.unicode.org/Public/UNIDATA/UnicodeData.txt
By the way, if you are already testing, can you see if the patch affects bug 252144? Thanks.
Comment on attachment 153729 [details] [diff] [review] patch r=jshin
Attachment #153729 - Flags: review?(jshin) → review+
I tested the patch. I applied the patch ( attachment 153729 [details] [diff] [review]) against Mozilla ver 1.6 (for 1.7 I should update my ports tree which I'll do as next). Mentioned patch corrects the bug 230838 (this one). Running the DHTML test (attachment 138992 [details]) shows following results: "Summary: 188 codepoint(s) passed; 0 codepoint(s) failed." everything is green:-) Unfortunately this patch doesn't affect bug 252144.
Thanks for testing. Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.