Closed Bug 230852 Opened 21 years ago Closed 21 years ago

[FIX]Non-cached image in table cell wraps unnecessarily

Categories

(Core :: Layout: Block and Inline, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: jruderman, Assigned: bzbarsky)

Details

(Keywords: regression, testcase)

Attachments

(2 files, 1 obsolete file)

Steps to reproduce:
1. Load the testcase.
2. Ctrl+Shift+R to load it again with the image not cached.
Result: After step 3, the link doesn't unwrap.

Alternate steps to reproduce:
1. Load the testcase.
2. Ctrl+R (so it doesn't wrap).
3. Resize the window to be very narrow.
4. Resize the window to be normal-sized.
Result: the link wraps (between the :before image and the link)
Expected: the link should not wrap, because there's plenty of room

Regression window (tested first set of steps with various Firebird builds):
good:   01/08 mozjf
broken: 01/10 scragz
broken: 01/13 mozjf

I discovered this bug by loading http://www.cs.hmc.edu/~jruderma/s/ (my start
page) with a user style sheet that adds http://mozilla.org/images/mozilla-16.png
before every link to mozilla.org.
Attached file testcase (obsolete) —
I can narrow the range to between 2004-01-08-07 and 2004-01-09-09.  Bernd, are
you sure the regression couldn't be after a Jan 8 evening build?

If so, the most likely culprit is bug 118117.  Otherwise, it could also be bug
190735....

Of course this could also be bug 210001, I guess.
It isn't 118117, I tried backing it out and that didn't help.
Attached file Simpler testcase
No need for :before.  This testcase shows the problem too.

I tried backing out bug 210001 locally and that did not help either.
Attachment #139005 - Attachment is obsolete: true
roc, this is all you.  See
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/html/base/src&command=DIFF_FRAMESET&file=nsBlockFrame.cpp&rev1=3.597&rev2=3.598&root=/cvsroot
the last hunk.  I did NOT review that change, and undoing it fixes this bug.
Component: Layout: Tables → Layout: Block and Inline
OS: Windows XP → All
QA Contact: core.layout.tables → core.layout.block-and-inline
Hardware: PC → All
Attached patch PatchSplinter Review
Comment on attachment 139292 [details] [diff] [review]
Patch

roc, would you review?
Attachment #139292 - Flags: superreview?(roc)
Attachment #139292 - Flags: review?(roc)
Assignee: nobody → bz-vacation
Priority: -- → P2
Summary: Non-cached :before image in table cell wraps unnecessarily → [FIX]Non-cached image in table cell wraps unnecessarily
Target Milestone: --- → mozilla1.7alpha
I think accidentally checked in his suggestion on bug 229052.
Comment on attachment 139292 [details] [diff] [review]
Patch

Yoikes! My bad! sorry sorry.
Attachment #139292 - Flags: superreview?(roc)
Attachment #139292 - Flags: superreview+
Attachment #139292 - Flags: review?(roc)
Attachment #139292 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: