230883 - when debug internal window with is closed, it remains in "Window" menu windows list.

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Alex Bitney]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.1; Linux)
Build Identifier: 

In Rhino debugger, files being debugged are opened as a JInternalFrames, and 
their list is maintained internally (caches) and also they appear in Window 
menu. When user closes the window, there's no handler to remove it from cache 
and from menu. 

Reproducible: Always

Steps to Reproduce:
1. Start JS debugger (org.mozilla.javascript.debugger.Main) 
2. Open several files. Note the list of files in "Window" menu. 
3. Close all windows with files. 
 
Actual Results:  
In "Window" menu all windows are still listed. 

Expected Results:  
There must be empty list. 

The cleanup code exists, but doesn't get called, as it is accidentally 
removed.

Comment 1

[Alex Bitney]

Attachment: patch

Comment 2

[Igor Bukanov]

The path is resonable, I will include it after testing

Comment 3

[Igor Bukanov]

Attachment: The version of the previous patch against CVS tip

The patch version that applies without fuzz to Rhino CVS tip.

Comment 4

[Igor Bukanov]

I committed the patch, thanks Alex for spotting this!

Comment 5

[Igor Bukanov]

Trageting as resolved against 1.5R5