nsFileStreams.h should not #include nsReadLine.h

VERIFIED FIXED

Status

()

VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsReadLine.h contains some static functions; when nsFileStreams includes that it
causes a build warning when nsFileStreams.h is included by nsNetModule.cpp
Attachment #139058 - Flags: superreview?(darin)
Attachment #139058 - Flags: review?(bz-vacation)
Status: NEW → ASSIGNED
Comment on attachment 139058 [details] [diff] [review]
patch

r=bzbarsky, though this static function really needs to go away...
Attachment #139058 - Flags: review?(bz-vacation) → review+
NS_InitLineBuffer can't easily be moved into a .cpp file, because spellchecker
uses it.

of course spellchecker reimplements NS_ReadLine, as an nsACString& version...
Oy.  a "line" makes no sense for an nsACString&, but whatever.

Updated

15 years ago
Attachment #139058 - Flags: superreview?(darin) → superreview+
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.