Closed Bug 231076 Opened 21 years ago Closed 21 years ago

Remove nsIPref from bookmarks

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mikael, Assigned: mikael)

References

Details

Attachments

(1 file, 1 obsolete file)

updated w/ Neils comment [checked in 040126]
4.93 KB, patch
Details | Diff | Splinter Review 
nsIPref switch to nsIPrefService
Status: NEW → ASSIGNED
Attached patch proposed patch (obsolete) — — Splinter Review 

    
  

        Attachment #139180 -
        Flags: superreview?(jag)

        Attachment #139180 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 139180 [details] [diff] [review]
proposed patch

sr=jag

        Attachment #139180 -
        Flags: superreview?(jag) → superreview+

    
  

        Attachment #139180 -
        Flags: review?(neil.parkwaycc.co.uk) → review?

    
  

        Attachment #139180 -
        Flags: review? → review?(p_ch)

    
    

    
  
Comment on attachment 139180 [details] [diff] [review]
proposed patch

r=pch, it would be nice if you could provide a patch for Firebird :)

        Attachment #139180 -
        Flags: review?(p_ch) → review+

    
    

    
  
Comment on attachment 139180 [details] [diff] [review]
proposed patch

>+            mPersonalToolbarName = NS_ConvertUTF8toUCS2(prefValue);
Change this to CopyUTF8toUTF16(prefValue, mPersonalToolbarName) and r=me.

[ This is begging to be a pref localized string ;-) ]

    
    

    
  


  
I filed bug 232106 for the localized stuff

        Attachment #139180 -
        Attachment is obsolete: true

    
  

        Attachment #139829 -
        Attachment description: updated w/ Neils comment → updated w/ Neils comment [checked in 040126]

    
  
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: