Remove nsIPref from bookmarks

RESOLVED FIXED

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Mikael Parknert, Assigned: Mikael Parknert)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

14 years ago
nsIPref switch to nsIPrefService
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

14 years ago
Created attachment 139180 [details] [diff] [review]
proposed patch
(Assignee)

Updated

14 years ago
Attachment #139180 - Flags: superreview?(jag)
Attachment #139180 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

14 years ago
Comment on attachment 139180 [details] [diff] [review]
proposed patch

sr=jag
Attachment #139180 - Flags: superreview?(jag) → superreview+
(Assignee)

Updated

14 years ago
Attachment #139180 - Flags: review?(neil.parkwaycc.co.uk) → review?
(Assignee)

Updated

14 years ago
Attachment #139180 - Flags: review? → review?(p_ch)

Comment 3

14 years ago
Comment on attachment 139180 [details] [diff] [review]
proposed patch

r=pch, it would be nice if you could provide a patch for Firebird :)
Attachment #139180 - Flags: review?(p_ch) → review+

Comment 4

14 years ago
Comment on attachment 139180 [details] [diff] [review]
proposed patch

>+            mPersonalToolbarName = NS_ConvertUTF8toUCS2(prefValue);
Change this to CopyUTF8toUTF16(prefValue, mPersonalToolbarName) and r=me.

[ This is begging to be a pref localized string ;-) ]
(Assignee)

Comment 5

14 years ago
Created attachment 139829 [details] [diff] [review]
updated w/ Neils comment [checked in 040126]

I filed bug 232106 for the localized stuff
Attachment #139180 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #139829 - Attachment description: updated w/ Neils comment → updated w/ Neils comment [checked in 040126]
(Assignee)

Updated

14 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.