231221 - pkits test script reporting incorrect results

Status: VERIFIED FIXED

(NSS :: Test, defect, P1)

Description

[Nelson Bolyard (seldom reads bugmail)]

The pkits test script checked in in nss/tests/pkits/pkits.sh
has several problems that cause it to report success on negative test cases 
that failed, and to report failure for some positive test cases that should
have succeeded.  
It also prompts the user for a password.
I have fixed these problems (patch forthcoming), and now the test results
are quite different than before.  I will file new bugs to reflect the new
failures.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

The script was reporting NO ERRORS, even though there were known and previously
reported errors occurring.  This patch corrects that.  

I have checked this patch in.  If reviewers decide this patch is not ideal,
then another more ideal patch can be checked in later.

/cvsroot/mozilla/security/nss/tests/pkits/pkits.sh,v  <--  pkits.sh
new revision: 1.2; previous revision: 1.1

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

I found another test case where the wrong cert file names had been given. 
Here's the patch:

Index: pkits.sh
===================================================================
RCS file: /cvsroot/mozilla/security/nss/tests/pkits/pkits.sh,v
retrieving revision 1.2
diff -u -r1.2 pkits.sh
--- pkits.sh    17 Jan 2004 05:04:42 -0000      1.2
+++ pkits.sh    17 Jan 2004 05:52:31 -0000
@@ -611,8 +611,8 @@
       $certs/TrustAnchorRootCertificate.crt

   VFY_ACTION="Valid RFC822 nameConstraints Test25"
-  pkits $certs/InvalidRFC822nameConstraintsTest24EE.crt \
-      $certs/nameConstraintsRFC822CA2Cert.crt \
+  pkits $certs/ValidRFC822nameConstraintsTest25EE.crt \
+      $certs/nameConstraintsRFC822CA3Cert.crt \
       $certs/TrustAnchorRootCertificate.crt

   VFY_ACTION="Invalid RFC822 nameConstraints Test26"

This case now passes.  Checked in.

/cvsroot/mozilla/security/nss/tests/pkits/pkits.sh,v  <--  pkits.sh
new revision: 1.3; previous revision: 1.2

Comment 3

[Bishakha Banerjee]

r=bb
Thanks, Nelson.

I didn't report Test 25 for Name Constraints, because these typos were fixed in
my workspace. I wasn't seeing that test fail. Ditto for teh "equal to" typo as
well. My workspace script has a lot of debug stuff in it, which I need to clean
up, and check in, this revision will have the CRLs loaded and unloaded (for the
ones not needed) as per your suggestion on Thursday.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Bishakha, I checked in my patches.  Please review the pkits.sh script to 
ensure that all the file names are correct, and then (if there are no more
errors) resolve this bug as fixed.  Thanks.

Comment 5

[Bishakha Banerjee]

Filenames are correct on the test cases. Resolving fixed.