231304 - JSS jar file should contain version information in the Manifest

Status: RESOLVED FIXED

(JSS Graveyard :: Library, enhancement)

Description

[Sean Timm]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

It would be helpful for the JSS jar file to contain version and vendor
information for the packages in JSS.

Reproducible: Always

Steps to Reproduce:
N/A
Actual Results:  
Implementation and specification versions and vendors are listed as null.

Expected Results:  
Provide implementation and specification versions and vendors

See
http://java.sun.com/products/jdk/1.2/docs/guide/versioning/spec/VersioningSpecification.html#PackageVersioning
and
http://java.sun.com/docs/books/tutorial/jar/basics/manifest.html

Comment 1

[Sandeep Konchady]

Attachment: Modified build_java.pl to use jar in place of zip and added lib/MANIFEST.MF

Modified build_java.pl to use jar in place of zip to generate
xpclass(_dbg).jar.  This modification allows the usage of -m flag to add
MANIFEST.MF file.  This file is located in mozilla/security/jss/lib directory
and contains version information of JSS being used.

Comment 2

[Saul Edwards]

Comment on attachment 182439 [details] [diff] [review]
Modified build_java.pl to use jar in place of zip and added lib/MANIFEST.MF

Is there some way you could add to the makefile so that it draws version
information (i.e., SECURITY_3_10_RTM or "4.1") from files that are already
being edited for each release?	We would like to avoid adding more files that
require manual editing.  Maybe you could talk to Christophe about that.

Also, in general you shouldn't change the indentation of other code unless
absolutely necessary.

Comment 3

[Sandeep Konchady]

Attachment: Autogenerate Manifest.mf for product version information in jss*.jar and also added a test for this.

Modified build_java.pl to use jar in place of zip to generate jss jar file. 
Autogenerate Manifest.mf for product version information in jss jar and also
added a test for this.

Comment 4

[glen beasley]

Comment on attachment 182816 [details] [diff] [review]
Autogenerate Manifest.mf for product version information in jss*.jar and also added a test for this.

this is great so far, but 
also add a jni method that would show the libjss C values in CryptoManager.c 
and jssver.h.

Comment 5

[Sandeep Konchady]

Attachment: Modifications to build and test system to display jss jar package, library and CryptoManager version information

BAsed on Glen's input here are the modifications

[1] build_java.pl : Autogenerate manifest.mf and use jar in place of zip to 
generate xpclass.jar/xpclass_dbg.jar.
[2] JSSPackageTest.java : This lists product package information for jss jar.
[3] all.pl : Added JSSPackageTest.java and also lists "Header" info from
jss4.dll or libjss4.so.

The output now looks like this:

============= Check JSS jar version
main: jss library loaded

---------------------------------------------------------
Checking jss jar and library version
---------------------------------------------------------
	      Introspecting jss jar file
Package name:	org.mozilla.jss
Spec title  :	Network Security Services for Java (JSS)
Spec vendor :	Mozilla Foundation
Spec version:	4.1
Impl title  :	org.mozilla.jss
Impl vendor :	Mozilla Foundation
Impl version:	4.1

  Fetching version information from CryptoManager
JSS_VERSION = JSS_4_1_RTM
NSS_VERSION = NSS_3_9_RTM
NSPR_VERSION = NSPR_4_5_RTM

  Checking for header information in jss library
libjss4.so = $Header: JSS 4.1 (debug)  May 12 2005 15:37:49 $

Comment 6

[glen beasley]

Comment on attachment 183452 [details] [diff] [review]
Modifications to build and test system to display jss jar package, library and CryptoManager version information

this looks good provided all the test machine platforms  have the utility
"strings". For windows MKS provides the utility "strings" but I do not believe
cygwin does.

Comment 7

[Saul Edwards]

Comment on attachment 183452 [details] [diff] [review]
Modifications to build and test system to display jss jar package, library and CryptoManager version information

Does this work on all platforms?  Just want to make sure this patch doesn't
affect all.sh on non-Unix platforms in a negative way.	Otherwise everything
looks good.

Comment 8

[Sandeep Konchady]

Modified build_java.pl to create a MANIFEST.MF file with JSS product version
information. 
This is then added to xpclass(_dbg).jar using jar -cvmf in place of zip -R. 

Modified all.pl to execute a new test that checks for product package version
information in 
jss4.jar as well as compare this to the version of library (libjss4.so or
jss4.dll) being used. 
This helps in consistency check for jss jar and associated lib. 

Added a new test JSSPackageTest.java that reads MANIFEST.MF from jss jar to
fetch product 
version information.

Output of the test looks like this:

============= Check JSS jar version
main: jss library loaded

---------------------------------------------------------
Checking jss jar and library version
---------------------------------------------------------
              Introspecting jss jar file
Package name:   org.mozilla.jss
Spec title  :   Network Security Services for Java (JSS)
Spec vendor :   Mozilla Foundation
Spec version:   4.1
Impl title  :   org.mozilla.jss
Impl vendor :   Mozilla Foundation
Impl version:   4.1

  Fetching version information from CryptoManager
JSS_VERSION = JSS_4_1_RTM
NSS_VERSION = NSS_3_9_RTM
NSPR_VERSION = NSPR_4_5_RTM

  Checking for header information in jss library
jss4.dll = $Header: JSS 4.1 (debug)  May 12 2005 11:27:58 $