231315 - stored 'bugs opened today' query stopped working after 2.16.x -> 2.17.6 upgrade

Status: RESOLVED DUPLICATE of bug 232164

(Bugzilla :: Query/Bug List, defect)

Description

[Joseph Heenan]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322)
Build Identifier: 

Bug opened following thread 'bug opened today problem with latest trunk 
bugzilla' in netscape.public.mozilla.webtools:

I had a stored query, the actual query (retreived from the namedqueries table)
is:

email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&em
ailreporter2=1&bugidtype=include&bug_id=&changedin=1&votes=&chfield=%
5BBug+creation%
5D&chfieldfrom=&chfieldto=Now&chfieldvalue=&short_desc=&short_desc_type=substrin
g&long_desc=&long_desc_type=substring&bug_file_loc=&bug_file_loc_type=substring&
field0-0-0=noop&type0-0-0=noop&value0-0-
0=&namedcmd=closed+bug+I+reported&newqueryname=bugs+opened+today&tofooter=1&orde
r=Reuse+same+sort+as+last+time

This shows a strange set of bugs, including ones opened today, but I think also 
including any changed today. Going to edit this query and then running it 
without any changes returns all bugs in the results.

Gerv replied:


> Right. the "changedin=1&chfield=%5BBug+creation%5D" part _should_ reduce it
> to "bugs created today". If it's not, there's a bug. Please file one, against
> the person who last changed that code, who is...
> 
> [e-mail] <Anthony Christofides>


Reproducible: Always

Steps to Reproduce:
1. click on stored query in page footer

Comment 1

[Joseph Heenan]

Gerv suggested I assign this to [e-mail], but bugzilla says I'm 
trying to change the bug status from unconfirmed to new and won't let me.

Comment 2

[Dave Miller [:justdave]]

Basically, what happened is the "changedin" field no longer exists.  Instead,
you do "[-1d] to [Now]" in the "any of the fields changed" section and just
don't pick a field.  We probably ought to convert the old url parameter on the
fly for backward compatibility purposes....

Comment 3

[Gervase Markham [:gerv]]

Dave: we have code to do that, but it's not working. Hence this bug.

Gerv

Comment 4

[Antonis Christofides]

This bug is actually a long story. The full story is at bug 37749 comment 26 and
bug 37749 comment 54. The summary:

The "view bugs changed today" link was incorrect. It shouldn't work at all. It
only worked because, by some coincidence, the search code had a bug which
happened, in that particular case, to return the desired result. When I rewrote
that part of the code (bug 37749), I deliberately re-introduced the error for
backwards compatibility; but Gerv, who reviewed my code, said no, we'll write
release notes. I said, OK, I hate backwards compatibility anyway.

So changedin *is* still processed, But the error (which was not much related to
changedin I think) does not exist anymore.

If you want, I can re-introduce the error: it's one line of code and three lines
of comments. As an alternative, we can tell people to correct their clearly
erroneous "today's bugs" links.

Comment 5

[Gervase Markham [:gerv]]

Yeah... I may have messed up there. I forgot about people's customised front
pages and saved queries.

Anthony: thanks for being so understanding. Could you post a patch here, and let
us know what the ramifications are?

Gerv

Comment 6

[[e-mail]]

Does Mozilla's QA/Bugs Filed Today use the right sort of query?

Comment 7

[Antonis Christofides]

Attachment: Patch - take one

Here. I only tested it briefly, and I believe it works; but it might be good if
more testing were done in landfill. I don't think there will be any side
effects whatsoever.

Should we inform the BMO admins about this? Make it block bug 231927
(bmo-regressions)?

Comment 8

[Antonis Christofides]

Attachment: Release note - take one

And this is a suggestion for release notes. First time I attempt to write
release notes, I don't know if I put it in the right place.

Comment 9

[Joseph Heenan]

Patch certainly fixes the problem, thanks.

It might be worth making checksetup.pl update any stored queries that make use
of this error?

Comment 10

[Antonis Christofides]

*** This bug has been marked as a duplicate of 232164 ***