Make "cumulate" option work properly in charts

RESOLVED FIXED in Bugzilla 2.18

Status

()

P2
normal
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

2.17.6
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(1 attachment)

Currently there are a few bugs in the "cumulate" option on new charts. 

Gerv
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [wanted for 2.17.7]?
Target Milestone: --- → Bugzilla 2.18
Created attachment 139375 [details] [diff] [review]
Patch v.1

This patch fixes 'cumulate' and a couple of other bugs/UI cleanups.

Gerv
Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Dave - can we sneak this in to remove some simple known bugs in charting?

Gerv
Attachment #139375 - Flags: review?(justdave)
Comment on attachment 139375 [details] [diff] [review]
Patch v.1

I have no clue what this is doing, and it'll take me longer to learn the chart
back end than we have between now and release time. Got someone else that knows
charts that can review it?
Attachment #139375 - Flags: review?(justdave) → review?
Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Kiko has reviewed my charts stuff in the past... is he around right now?

Gerv
Attachment #139375 - Flags: review?(kiko)

Comment 5

15 years ago
Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Looks quite correct. Make sure (I guess you have) that the wrapped buglist.cgi
link is actually working, since I'm a bit fuzzy on how chomping might work
there.

Again, a simple comment would have helped me understand what sort of changes
you intended there, but at least this one was short!
Attachment #139375 - Flags: review?(kiko) → review+
Requesting appr
Flags: approval?
Flags: approval? → approval+
Fixed.

Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/reports/chart.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/chart.png.tmpl,v
 <--  chart.png.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.241; previous revision: 1.240
done
Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.3; previous revision: 1.2
done

Gerv
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Whiteboard: [wanted for 2.17.7]? → [wanted for 2.17.7]

Updated

15 years ago
Attachment #139375 - Flags: review?
Whiteboard: [wanted for 2.17.7]
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.