231427 - Moving between tabs loses the icon in Location Bar

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Mark Patterson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040118
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040118

If you have a little icon to the left of the URL, and a number of other pages
open in tabs, then you move to one of the other tabs and back again, the icon
reverts to the default bookmark one.


Reproducible: Always

Steps to Reproduce:
1. Get a number of tabs open. Any will do.
2. Open a new tab and go to a page with an icon, e.g. ximian.com. Verify that
the little monkey icon is there in the address window to the left of the "http:"
3. Move back to one of the earlier tabs
4. Come back to the ximian one

Actual Results:  
The little monkey icon is lost from the address bar, and replaced with the
default bookmark one.

Expected Results:  
It should have kept the icon

Comment 1

[Adam Hauner]

Confirming as NEW using 2004021900/trunk/W2K and 20040217/trunk/Linux

It's regression since M1.4, I'll try to get smaller time window.
xref: bug 129282

Comment 2

[Adam Hauner]

1.6b build (20031208) and 1.6final (20040113) are correct, but 20040101/trunk
build and later are wrong. I don't have any build between these days, but
regression have to be early in 1.7a developement.

Boris, I'm sorry to bother you, but who could be able to track this regression
in checkings?

Comment 3

[Boris Zbarsky [:bzbarsky]]

With the following steps:

1)  Start mozilla pointing at this bug
2)  Open a new tab (which shows about:blank) using Ctrl-T
3)  Go back to this bug

I see this issue in the 2003-12-08 build, as well as 2003-11-01.  I didn't
bother testing further.

Comment 4

[Adam Hauner]

Boris: IMHO there are two situations: Mark's repro from bug's description fits
Testcase A, your's repro in comment #3 fits Testcase B:

Testcase A
1.  leave 1st tab blank or with any content 
2.  open a new 2nd tab using Ctrl-T
3.  load http://www.mozilla.org/ in this tab
4.  open a new 3rd tab using Ctrl-T
5.  go back to 2nd tab

OK:  1.4/20030624, 1.6b/2003120808, 1.6/20040113
Broken: trunk/20040101, 1.7a/20040219

Testcase B
1.  open http://www.mozilla.org/ in browser's 1st tab
2.  open a new tab using Ctrl-T
3.  go back to 1st tab

OK: maybe never
Broken: 1.3.1, 1.4/20030624, 1.6b/2003120808, 1.6/20040113, trunk/20040101,
1.7a/20040219

Comment 5

[Boris Zbarsky [:bzbarsky]]

Looks like testcase A broke between 2003-12-20-09 and 2003-12-21-09.

I see nothing there that should have affected this behavior, so I am guessing
the brokenness from testcase B now affects testcase A too, for some reason.  The
right thing to do is to fix B; then A should be fixed too.

Comment 6

[Jesiah S]

*** Bug 236013 has been marked as a duplicate of this bug. ***

Comment 7

[Rob Janssen]

Tested with 1.7RC2 but it is still broken.  We seem to be stuck with this one
for 1.7

Comment 8

[Andrew Turnbull]

*** Bug 245496 has been marked as a duplicate of this bug. ***

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

This bug was probably fixed by my patch for bug 289609.  Please resolve this
FIXED if it works properly now.

Comment 10

[Andrew Schultz]

testcase A as described in comment 4 works with linux trunk 2005041705 (before
bug 289609) and is broken in 2005041505 (before bug 289609)

testcase B sounds like bug bug 129282

resolving FIXED-by-bug 289609