231499 - Cookie Manager: Ctrl+Left-Click to select multiple items is broken in 1.6

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[weed_richard]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

In Cookie Manager, if you use Ctrl+Left-Click to select multiple cookies to remove and then hit Remove Cookie, the display just blanks out (without removing) those lines in the list.  If you close and reopen the window, you see that the cookies were *not* deleted.

If you delete the cookies one at a time, it works fine.  This worked fine in 1.3.x...just noticed when I upgraded to 1.6.

Only tested in Windows 2000.


Reproducible: Always

Steps to Reproduce:
1.  Open Cookie Manager.
2.  Using Ctrl+Left-Mouse-Click, select multiple cookies to remove and hit Remove Cookie.
3.  Close Cookie Manager.
4.  Open Cookie Manager again...you will see that the cookies were *not* removed.

Actual Results:  
The problem occurred.

Expected Results:  
It should have removed the selected cookies.  Also, it should not have just blanked out the lines in the display.

Comment 1

[weed_richard]

Important:  To recreate the bug, the items you select must *not* be grouped together in the list.  Example:  If there are 5 cookies, pick 1, 3, and 5 using Ctrl+Left-click.

Comment 2

[jon rekai]

Same behavior with 1.6 on FreeBSD, i.e. cookie 1 disappears from the list,
cookies 3 and 5 go blank (but remain selected/highlighted?) and none of the
cookies get deleted.  

Hitting "Remove" two more times appears to accomplish the original objective of
removing all three.

Same behavior is occurring with a trunk pull from last night.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

-> cookies, and confirming on linux 2004011608
No javascript console messages

Comment 4

[jon rekai]

This is what I'm seeing in the js console when the remove is attempted (.6 and
trunk):

Error: cookies[idx] has no properties
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 314

Error: cookies[row] has no properties
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 165

Error: cookies[row] has no properties
Source File: chrome://communicator/content/wallet/CookieViewer.js
Line: 167

Comment 5

[jon rekai]

http://lxr.mozilla.org/seamonkey/source/extensions/wallet/cookieviewer/resources/content/nsWalletTreeUtils.js#63
appears to be causing prematurely exit of the loop.

Comment 6

[OstGote!]

The Hardware/OS should be All/All - see the comments. And IMO the keyword
regression should be included. This has worked with 1.5.

Comment 7

[Mike Connor [:mconnor]]

-> me

Comment 8

[Mike Connor [:mconnor]]

Neil, any idea why rowCountChanged fails here?  it only happens with the
selections aren't contiguous.

also, why did you remove the part of the code that keeps the scroll position?

Comment 9

[[e-mail]]

Attachment: Proposed patch

We're getting spurious tree notifications. The old code used to ignore the
resulting exceptions but these days they propagate out of rowCountChanged :-/
Note that setting selectEventsSuppressed to false merely postpones select
events until it is set back to true again.

Comment 10

[[e-mail]]

Comment on attachment 139658 [details] [diff] [review]
Proposed patch

Well when I say spurious I mean unwanted.

Comment 11

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 231977 has been marked as a duplicate of this bug. ***

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 232799 has been marked as a duplicate of this bug. ***

Comment 13

[Darin Fisher]

Comment on attachment 139658 [details] [diff] [review]
Proposed patch

rs=darin

Comment 14

[[e-mail]]

Fix checked in.

Comment 15

[Josh Birnbaum]

*** Bug 251312 has been marked as a duplicate of this bug. ***