231510 - move spellchecker UI files into extensions/spellcheck

Status: RESOLVED WONTFIX

(Core :: Spelling checker, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The files that form the spellcheck UI live somewhere in /editor. It was put
there when only NS had a spellchecker.
But these days, mozilla has its own spellchecker. In my opinion, it would make
sense to put the UI into /extensions/spellcheck, next to the backend code.
If we want to have spellchecking in other parts, like forms on webpages, /editor
doesn't make sense anymore. (firebird doesn't want to build UI files in editor i
guess)
spellchecker is really an extension, so it could happily live there. no need to
move to a more core dir.

Comment 1

[timeless]

um...

you have a serious dependency problem. core isn't supposed to depend on non
core. and editor is really two things, ender and composer. ender is needed by
any gui thing. you won't be able to do firebird w/o it (in fact these days
firebird needs all of midas, so it can barely skimp on even composer ui...).

anyway... i get annoyed enough when extensions depend on eachother. I don't want
core to depend on an extension.

</rant>

also, whatever you do, please keep the interface glue distinct from myspell, i
might want to replace it w/ the system spellchecker on macosx or windows...

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

How does core depend on the ui for spellchecker. imo, spellchecker is an
extension to editor. Editor can be quite happy without spellcheck capability.
So i fail to see the dependency problem.

I think spellcheck/src should contain the glue, and spellcheck/myspell the real
spellchecker. Stuff like mozEnglishWordsUtils should move into myspell i think.
But that is another bug :)
the UI should not talk to myspell, but only to the glue. If we do that, you can
replace myspell with whatever you want.

Comment 3

[timeless]

oh, sorry, i was just afraid you were going to move the idl files ..., don't ask
me why, i must have been out of it.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: Patch after move v1

I suggest those cvs moves:

editor/ui/dialogs/content/EdSpellCheck.js -> 
    extensions/spellcheck/resources/content/spellcheck.js
editor/ui/dialogs/content/EdSpellCheck.xul ->
    extensions/spellcheck/resources/content/spellcheck.xul
editor/ui/dialogs/content/EdDictionary.js ->
    extensions/spellcheck/resources/content/personalDictionary.js
editor/ui/dialogs/content/EdDictionary.xul ->
    extensions/spellcheck/resources/content/personalDictionary.xul
editor/ui/dialogs/locale/en-US/EditorSpellCheck.dtd ->
    extensions/spellcheck/resources/locale/en-US/spellcheck.dtd
editor/ui/dialogs/locale/en-US/EditorPersonalDictionary.dtd ->
    extensions/spellcheck/resources/locale/en-US/personalDictionary.dtd

It includes renaming the files, because keeping the Ed prefix doesn't make
sense in the new location.

The patch attached makes those file know about their new locations and put them
into some jar.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 143046 [details] [diff] [review]
Patch after move v1

The review would include the move as in comment 4

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: After the move, make the files used

This patch makes the files used in there new location.
(so the move i mentioned should be a copy, until this patch is in.)

Comment 7

[Mike Kaply [:mkaply]]

I disagree with this move.

If we move the spellchecker UI into extensions, we are requiring that anyone
that provides a spellchecker provide a translation of the spellchecker UI.

Although everyone believes that the Mozilla spellchecker is the "only
spellchecker", this might not be the case if a third party decides to use a
different spellchecker.

The UI should stay in a place where it gets translated with the rest of Mozilla.

Comment 8

[timeless]

Comment on attachment 143046 [details] [diff] [review]
Patch after move v1

i think i agree w/ mkaply

Comment 9

[timeless]

let's not fix this