231566 - pk12util erroneously reports error -8173, no memory

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Emil Assarsson had some trouble with pk12util.  He did some debugging, and 
wrote:

> I have a problem with some allocation errors in SEC_PKCS12AddCertAndKey(). 
> I have the same error if I use SEC_PKCS12CreatePasswordPrivSafe().
>
> I get a return value != SECSuccess and the PR_GetError() is returning a 
> -8173 (SEC_ERROR_NO_MEMORY). 
> Is this related to the arena from the ExportContext? 
> And what can I do about it? 

I looked into it, and found several bugs in pk12util that cause wrong error
messages to be shown.  I also found several misnamed functions, and found
that the Usage message was not being displayed when it should be.  

Patch forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Fixes problems reported above.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 139488 [details] [diff] [review]
patch v1

Bob, please review

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Target NSS 3.9.1

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/cmd/pk12util/pk12util.c,v  <--  pk12util.c
new revision: 1.28; previous revision: 1.27