23161 - [dogfood][EVENTTARG] Can't click on right hand URLs on CNET

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[chriss]

Build: 2000010408

Steps to reproduce:
1) Go to http://www.news.com
2) Click on
any news article. e.g.:
http://news.cnet.com/news/0-1003-200-1513804.html?tag=st.ne.1002.thed.1003-200-1513804
4) Notice that you cannot click on any of the URLs on the right side under
"Latest Headlines"

Note that I filed a similar bug (13275) but I don't think they are related as
Amazon links seem to work OK for me.

Comment 1

[leger]

PDT+

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think I have a fix for this, but it's more of a band-aid than a real fix.
It's just less likely to be wrong in common situations.  (I haven't tested it
thouroughly yet.)  I'll attach it if someone wants to look at it...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible fix

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This would be wrong in the case where inline content overlaps a floater (which
can happen for various reasons, all of them rather obscure, for example,
negative margins, negative text-indent, really long words or other overflow,
etc.).   GetFrameForPoint really needs to be the exact reverse of Paint...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 22759 has been marked as a duplicate of this bug. ***

Comment 6

[karnaze (gone)]

*** Bug 23505 has been marked as a duplicate of this bug. ***

Comment 7

[John Morrison]

Note that events are also stolen from form widgets in a left|right float.
(see attachment to bug #23505). [But joki and dbaron knew that already].

Comment 8

[joki (gone)]

I have committed dbaron's fix.  I also added some additional bits which should
fix a number of other targetting issues.

Comment 9

[joki (gone)]

*** Bug 20557 has been marked as a duplicate of this bug. ***

Comment 10

[joki (gone)]

*** Bug 21678 has been marked as a duplicate of this bug. ***

Comment 11

[joki (gone)]

*** Bug 23344 has been marked as a duplicate of this bug. ***

Comment 12

[joki (gone)]

*** Bug 22812 has been marked as a duplicate of this bug. ***

Comment 13

[joki (gone)]

*** Bug 23795 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Petersen]

Fixed in the Jan 2Oth build.