231651 - gNavigatorBundle is not defined

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[HJ]

Steps to reproduce (mozilla build 2004010708):

1) clear location bar history
   - Menu/Edit/Preferences/Navigator/History/Clear Location Bar

2) use Menu/File/Open Web Location (Ctrl+Shift+L)

3) click on the drop down arrow (textfield)

Current result:

Error: gNavigatorBundle is not defined
Source File: chrome://navigator/content/sessionHistoryUI.js
Line: 139

gNavigatorBundle is defined here:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#427
like this:
var gNavigatorBundle = document.getElementById("bundle_navigator");

It is used in function createUBHistoryMenu() and that is called from two
different XUL files:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.xul#192
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/openLocation.xul#66
like this:
var na = gNavigatorBundle.getString("nothingAvailable");

So we need to add something like this:

<stringbundle id="bundle_navigator"
src="chrome://navigator/locale/navigator.properties"/>

  <script type="application/x-javascript">
    <![CDATA[
      var gNavigatorBundle = document.getElementById("bundle_navigator");
    ]]>
  </script>

here:
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/openLocation.xul#52

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[HJ]

Yeah, that <script> thing was stupid. I completely missed openLocation.js while
I was demontrating the powers of the mozilla MultiZilla combo. At least they
learned how to file bug reports.

Comment 3

[jag (Peter Annema)]

Comment on attachment 139535 [details] [diff] [review]
Proposed patch

sr=jag

Comment 4

[[e-mail]]

Fix checked in.