23169 - can't insert line breaks in the middle of an existing line (plaintext)

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Akkana Peck]

Go to the bugzilla bug page.  Click in the text area for long description.  Type
some stuff.  Click back in the middle of a line you just typed.  Hit return.
Observe that nothing happens.  There's no way to split an existing line.

Comment 1

[Joe Francis]

i noticed this worked for me, and talked to akkana about it.  Turns out we see it
in commercial optimized build, but not mozilla debug build.  I kinda suspect this
may not be an editor problem, but I'll look into it.

Comment 2

[Joe Francis]

i did an optimized build on mac and still cant reproduce this problem.  Akkana is
going to try to generate a fresh opt linux build and see what happens.

Comment 3

[Akkana Peck]

Update: I have an optimized build today, and I do see the problem.  I'm using
printfs to track the problem down further (SplitNode is failing for some reason).

Comment 4

[Akkana Peck]

The problem was that result was uninitialized at the beginning of SplitNodeImpl.

Isn't there any way to get the Mac build system to show uninitialized variable
warnings?  I see several more of these in the editor code.

Taking bug -- will check in a fix as soon as I get Joe's review.

Comment 5

[Akkana Peck]

Turns out Linux builds don't show this warning for debug builds (and hence
they're not on the warnings page) either.

I'm talking to slamm and mcafee about how we can get these warnings to show up
on the warnings page.

Comment 6

[Joe Francis]

i reviewd and approved akkana's changes.  thanks akkana!

Comment 7

[Akkana Peck]

Fixed -- we fixed several more uninitialized variables while we were in there.

Comment 8

[sujay]

verified in 1/13 build.

Comment 9

[rubydoo123]

setting to an approximate milestone so it can be off of the no TFV list