231734 - [BEOS]Random crashes in CallMethod

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Sergei Dolgov]

Mozilla crashes randomly, complaining in stack crawl about segmentation violation
in Bview->::BVindow.
Reason - focus messages.
If for nsWindow::SetFocus() we have check fro GUI-thread, so GOTFOCUS messages
always pass to proper/existing target (i hope), for LOSTFOCUS messages situation
is different. Those are generated "automatically" by nsViewBeOS and when BWindow
pointer in nsMethodInfo->args reaches CallMethod, originating BWindow with its
whole thread  may be already gone, so BWindow/Looper message filters gets
segment violation when casts uint32 to non existing (BWindow *).
Solution - it seems in current situation we don't need that check for
mView->BWindow == (BWindow *)info->args[];
So, i will remove that test in ::CallMethod

Comment 1

[Sergei Dolgov]

Attachment: Patch (diff -up -r HEAD)

Removing unused args for MethodInfo

Comment 2

[Sergei Dolgov]

Comment on attachment 139585 [details] [diff] [review]
Patch (diff -up -r HEAD)

review request

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in widget/src/beos/nsWindow.cpp;
/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.76; previous revision: 1.75
done