Allow selection of text in gtk popup windows

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
15 years ago
6 years ago

People

(Reporter: crispin, Assigned: blizzard)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040121 Galeon/1.3.11a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040121 Galeon/1.3.11a

The Gnome HIG recommends that text inside alert windows is selectable:

http://developer.gnome.org/projects/gup/hig/1.0/windows.html#alerts-information

This would allow people for instance to select text from javascript alert
messages etc.

Attached is a one-liner patch to make the gtk EmbedPrompter class have
selectable text.

See also bug 60513, which is the bug for selectable text in the XUL alerts.

Reproducible: Always

Steps to Reproduce:
Created attachment 139601 [details] [diff] [review]
Allow the label text to be selectable

Updated

15 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #139601 - Flags: review?(blizzard)
Attachment #139601 - Flags: superreview?(bryner)
(Assignee)

Comment 2

15 years ago
Comment on attachment 139601 [details] [diff] [review]
Allow the label text to be selectable

Looks good to me.
Attachment #139601 - Flags: review?(blizzard) → review+
Attachment #139601 - Flags: superreview?(bryner) → superreview+
Thanks for the r= and sr=, now it has both, could someone please check in the patch.
This was checked in by neil, thanks :-)
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Component: Embedding: GTK Widget → Embedding: GTK Widget
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.