Closed Bug 231810 Opened 20 years ago Closed 20 years ago
Incorrect prompt when copying address records between address books
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6) Gecko/20040117 Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6) Gecko/20040117 When copying address records from one address book to another, the prompt in the bottom line always reads "0 card(s) copied" even when the records in reality have been copied correctly. Reproducible: Always Steps to Reproduce: 1.select address record(s) in address book 1. 2.drag with mouse to another address book. 3.release mouse button Actual Results: All selected records were copied but the prompt read "0 card(s) copied" Expected Results: "xx card(s) copied"
Confirming with a current CVS build on Linux.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Incorrect prompt when copying address recoords between address books → Incorrect prompt when copying address records between address books
This is a regression from bug 205709. This getFormattedString() call here http://lxr.mozilla.org/mozilla/source/mailnews/addrbook/resources/content/abDragDrop.js#168 needs to use j now, too. Not i. I'll upload a patch in a minute.
Assignee: sspitzer → borggraefe
Actually it's even more logical to use numrows instead of j. j equals numrows after the for-loop anyway. I also split the string "%S card(s) moved" into "1 card moved" and "%S cards moved". I think this is better English.
Attachment #139675 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 139675 [details] [diff] [review] Patch Gosh, the indentation in this file is awful :-/ Nit: You don't need the ()s around the whole expression.
Attachment #139675 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #139675 - Flags: superreview?(mscott) → superreview+
This is the same patch as before just with the parenthesis around ? : removed. Ready for checkin. :-)
Checked in by timeless. He accidentally checked in the first patch. Since there is only a stylistic difference between the two patches, I guess it's not that important. timeless said "blame me". ;-) Marking FIXED anyway. :-)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
timeless just corrected his small mistake.
You need to log in before you can comment on or make changes to this bug.