231810 - Incorrect prompt when copying address records between address books

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Stephan Bucher]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6) Gecko/20040117
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.6) Gecko/20040117

When copying address records from one address book to another, the prompt in the
bottom line always reads "0 card(s) copied" even when the records in reality
have been copied correctly.

Reproducible: Always

Steps to Reproduce:
1.select address record(s) in address book 1.
2.drag with mouse to another address book.
3.release mouse button

Actual Results:  
All selected records were copied but the prompt read "0 card(s) copied"

Expected Results:  
"xx card(s) copied"

Comment 1

[Stefan Borggraefe]

Confirming with a current CVS build on Linux.

Comment 2

[Stefan Borggraefe]

This is a regression from bug 205709. This getFormattedString() call here

http://lxr.mozilla.org/mozilla/source/mailnews/addrbook/resources/content/abDragDrop.js#168

needs to use j now, too. Not i.

I'll upload a patch in a minute.

Comment 3

[Stefan Borggraefe]

Attachment: Patch

Actually it's even more logical to use numrows instead of j. j equals numrows
after the for-loop anyway.

I also split the string "%S card(s) moved" into "1 card moved" and "%S cards
moved". I think this is better English.

Comment 4

[[e-mail]]

Comment on attachment 139675 [details] [diff] [review]
Patch

Gosh, the indentation in this file is awful :-/

Nit: You don't need the ()s around the whole expression.

Comment 5

[Stefan Borggraefe]

Attachment: Same patch with Nit addressed

This is the same patch as before just with the parenthesis around ? : removed.
Ready for checkin. :-)

Comment 6

[Stefan Borggraefe]

Checked in by timeless. He accidentally checked in the first patch. Since there
is only a stylistic difference between the two patches, I guess it's not that
important. timeless said "blame me". ;-)

Marking FIXED anyway. :-)

Comment 7

[Stefan Borggraefe]

timeless just corrected his small mistake.