Closed Bug 231849 Opened 21 years ago Closed 21 years ago

[BEOS] Network optimizations from UNIX

Categories

(NSPR :: NSPR, enhancement)

x86
BeOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: thesuckiestemail, Assigned: wtc)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7a) Gecko/20040122 Firebird/0.8.0+
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7a) Gecko/20040122 Firebird/0.8.0+

As the BeOS under BONE network code is mostly identical to UNIX I moved over
some missing optimizations from there. Seems to work just fine.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch UNIX net-optimizations (obsolete) — Splinter Review
These are the same to those on UNIX except we run under bthreads so we only
need native thread implementation.
Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

review request
Attachment #139670 - Attachment description: The UNIX optimizations → UNIX net-optimizations
Attachment #139670 - Flags: review?(darin)
CC'ing sergei_d
Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

please don't use the word "Stolen" in code... it gets some people overly
excited ;-)

nit: your indentation is inconsistent.	there is a mix of tabs and spaces used
for indentation.
Attachment #139670 - Flags: review?(darin) → review+
Comment on attachment 139670 [details] [diff] [review]
UNIX net-optimizations

1. Remove the "Stolen from ../unix/unix.c" comments.

2. Format the code in the prevalent indentation style
of bnet.c.
Attached patch Cleaned up patchSplinter Review
Ok, this one should be cleaner.

(Thanks for reviewing this, I'm not sure who to turn to about BeOS specific
nspr-patches.)
Attachment #139670 - Attachment is obsolete: true
Comment on attachment 140251 [details] [diff] [review]
Cleaned up patch

requesting sr

(and hoping for someone with cvs-access to commit it if passed)
Attachment #140251 - Flags: superreview?(wchang0222)
Comment on attachment 140251 [details] [diff] [review]
Cleaned up patch

r=wtc.
Attachment #140251 - Flags: superreview?(wchang0222) → superreview+
patch landed on NSPRPUB_PRE_4_2_CLIENT_BRANCH for 1.7 beta.  leaving open for
wtc to land patch on NSPR trunk.
Patch checked in on the NSPR trunk for NSPR 4.5.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: