23189 - FTP file picker not initiating download (window.close problem)

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Judson Valeski]

Goto a FTP site to download a file (large or small). Click the file. The file
picker dialog comes up and when it is ok'd, nothing is downloaded. A progress
dialog might be flashing up for an instant, but no file is created and no data
is transfered.

Comment 1

[Akkana Peck]

This was split off from bug 23039, and this one is the real reason that ftp
downloads aren't working.  So the PDT+ should be on this bug, not that one,
since this prevents the user from using the product to download new versions of
itself.

Comment 2

[leger]

FTP has to work. PDT+

Comment 3

[Judson Valeski]

Akkana and I viewed the FTP log output on her machine. The URI load does not
start (as it should) after the user clicks "ok" to initiate the download.

Comment 4

[don]

Bill, is this our bug?

Comment 5

[Bill Law]

After extensive investigation, Dan Matejka and I discerned that the problem was
that the "window.close()" in unknownContent.js was somehow causing dismissal of
the download progress dialog before that dialog could do its job.

I've checked in a workaround that defers the close slightly by wrapping it in a
window.setTimeout call.  This seems to get the download working again on Mac and
Linux with no ill-effects.

I'm reassigning this bug to Dan and removing the [DOGFOOD] marker.  I'd suggest
that the [PDT+] be removed.  There is still something flaky that needs fixing,
but it isn't as high priority now, with my workaround.

Comment 6

[Akkana Peck]

Sure enough, I just downloaded a new build successfully -- thanks!  One issue,
though: there's no way to tell when the download is finished, because the
progress window doesn't pop down at the end of the download.  I had to go to a
shell window and repeatedly ls -l the file to see if it had stopped changing
(which isn't a reliable method).  Should that be filed as a separate bug, or can
it be lumped into this one?

Comment 7

[Paul MacQuiddy]

setting sairuh as qa contact

Comment 8

[leger]

Yes, removing the PDT+.:-)

Comment 9

[Dan M]

See also bug 24903; a similar problem with a similar temporary workaround.

Comment 10

[Dan M]

.

Comment 11

[sairuh (rarely reading bugmail)]

looks fine to me. verified on linux, mind you, so someone could verify on SGI as
well, that'd be great (or, just reopen if this is still a problem on irix). thx.