nsProxyObject does not need to inherit from nsISupports

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
Currently nsProxyObject inherits from nsISupports just (apparently) so it can be
refcounted.  It would be more performant for it to just implement its own
refcounting, since the addref and release would not need to be virtual and there
would not need to be a vtable pointer.
(Assignee)

Comment 1

14 years ago
Created attachment 139781 [details] [diff] [review]
patch

This does the change I mention above, along with a couple of warning fixes in
the proxy code.  I'm assuming the note about the 'mac compiler' is no longer
relevant.    I also inlined a couple of getters and made the dtor nonvirtual.
(Assignee)

Updated

14 years ago
Attachment #139781 - Flags: superreview?(dbaron)
Attachment #139781 - Flags: review?(dougt)
Attachment #139781 - Flags: superreview?(dbaron) → superreview+

Updated

14 years ago
Attachment #139781 - Flags: review?(dougt) → review+
(Assignee)

Comment 2

14 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.