Closed
Bug 232022
Opened 21 years ago
Closed 21 years ago
nsProxyObject does not need to inherit from nsISupports
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
|
8.69 KB,
patch
|
dougt
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Currently nsProxyObject inherits from nsISupports just (apparently) so it can be refcounted. It would be more performant for it to just implement its own refcounting, since the addref and release would not need to be virtual and there would not need to be a vtable pointer.
|
Assignee | |
Comment 1•21 years ago
|
||
This does the change I mention above, along with a couple of warning fixes in the proxy code. I'm assuming the note about the 'mac compiler' is no longer relevant. I also inlined a couple of getters and made the dtor nonvirtual.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139781 -
Flags: superreview?(dbaron)
Attachment #139781 -
Flags: review?(dougt)
Attachment #139781 -
Flags: superreview?(dbaron) → superreview+
|
||
Updated•21 years ago
|
Attachment #139781 -
Flags: review?(dougt) → review+
|
|
Assignee | |
Comment 2•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•