232120 - Now NetBSD have pthread support, but mozilla can't properly configure

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Shin'ichiro TAYA]

User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.6) Gecko/20040117
Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.6) Gecko/20040117

(1) mozilla/configure blindly disables pthreads on NetBSD
(2) mozilla/nsprpub/configure does not define macro and does not supply ld
argument '-pthread'
(3) _PRSockOptVal_t is not defined for NetBSD in
mozilla/nsprpub/pr/src/pthreads/ptio.c


Reproducible: Always

Steps to Reproduce:
make mozilla on NetBSD-current

Actual Results:  
not configured to use native pthread


Expected Results:  
configured to use pthread

Comment 1

[Shin'ichiro TAYA]

Attachment: patch to fix this bug

this patch is used for NetBSD pkgsrc system.
so known to be worked.
please merge this patch.

Comment 2

[Wan-Teh Chang]

Comment on attachment 139837 [details] [diff] [review]
patch to fix this bug

r=wtc.	Taya, are you sure that on NetBSD we
need to define both -D_REENTRANT and -D_THREAD_SAFE?

On FreeBSD, we were told that -pthread cannot be used
for compiling and should only be used for linking.
Is it the same way on NetBSD?

Comment 3

[Shin'ichiro TAYA]

For nsprpub/configure.in part, I simply copied From FreeBSD & modified about
_PTHREAD_LDFLAGS.
These patches are not needed for NetBSD sources(I mean /usr/include/*.h or
/usr/include/*/*.h).
If these defines are not needed for mozilla sources, I will remove them and
regen patches.


About -pthread issue, there is no restriction like FreeBSD.

Comment 4

[Wan-Teh Chang]

nsprpub does not need _REENTRANT or _THREAD_SAFE.
Usually the pthreads man page documents which
macros need to be defined if you use pthreads.
If the compiler supports a -pthread or -pthreads
flag, that flag will take care of any necessary
macro defines.

Comment 5

[Shin'ichiro TAYA]

I could build & run mozilla without explicitly define _REENTRANT or _THREAD_SAFE.
-pthread option is enough.
I'll post new patch later.

Comment 6

[Shin'ichiro TAYA]

Attachment: new patch for nsprpub/configure.in

Comment 7

[Wan-Teh Chang]

Comment on attachment 140307 [details] [diff] [review]
new patch for nsprpub/configure.in

r=wtc.

Taya, do we still need to change mozilla/configure.in and
mozilla/nsprpub/pr/src/pthreads/ptio.c?  These two files
are modified in your old patch.

Comment 8

[Shin'ichiro TAYA]

Yes, both are needed.

Comment 9

[Wan-Teh Chang]

Comment on attachment 139837 [details] [diff] [review]
patch to fix this bug

I checked in the NSPR patches on the NSPR trunk (NSPR 4.5.1)
and NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.7a).

Darin, could you superreview the mozilla/configure.in change
in this patch?

Comment 10

[Darin Fisher]

Comment on attachment 139837 [details] [diff] [review]
patch to fix this bug

sr=darin

Comment 11

[Wan-Teh Chang]

Last patch checked into the Mozilla trunk.

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1320; previous revision: 1.1319
done

All the changes will be in Mozilla 1.7 beta.

Comment 12

[Shin'ichiro TAYA]

I could build & run mozilla with latest source check out from CVS.
Thank you!