Closed Bug 232158 Opened 22 years ago Closed 10 years ago

lxr_url and lxr_root explanations in editparams.cgi don't make sense

Categories

(Bugzilla :: Attachments & Requests, defect)

Product:
Bugzilla
Component:
Attachments & Requests
Version:
2.17.6
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Waldo, Unassigned)

References

(
URL
)

Details

For bug 232141, when I use the new diff viewer to view the diff, clicking on the LXR link that should go to the source code for the altered file does not go there. It goes here: http://lxr.mozilla.org//source/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl ...instead of going to the correct URL: http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/template/en/default/global/useful-links.html.tmpl My best guess is that this is a problem with the top-level setting for where source links should point (i.e., it's http://lxr.mozilla.org/ instead of http://lxr.mozilla.org/mozilla/ or some such error), but as I haven't looked at any code I could be wrong.
Assignee: myk → john
I just tested on a few other bugs. It appears to be common for the whole system of patches. Also, reassigning correctly as this does look to be a b.m.o issue, not a Bugzilla issue.
Component: Attachments & Requests → Bugzilla: Other b.m.o Issues
Product: Bugzilla → mozilla.org
Version: unspecified → other
This is a bug in Bugzilla. The lxr_root parameter is correctly set to use mozilla/ on bugzilla.mozilla.org.
Component: Bugzilla: Other b.m.o Issues → Attachments & Requests
Product: mozilla.org → Bugzilla
Version: other → 2.17.6
*** Bug 232364 has been marked as a duplicate of this bug. ***
Fixed on b.m.o by making lxr_url be http://lxr.mozilla.org/mozilla and lxr_root be mozilla/. I'm not sure if this is the way it's supposed to work. If so, it's certainly confusing; had me scratching my head for a while looking at the code before I figured it out, and I'm the first so far. Leaving this bug open and morphing it into a documentation bug for describing the role of these two parameters better.
Summary: LXR link to source view does not work from diff viewer → lxr_url and lxr_root explanations in editparams.cgi don't make sense
No longer blocks: bmo-regressions-old
Hmm. This is not the way it's supposed to work actually. It should be http://lxr.mozilla.org and mozilla if I recall correctly, so it must be a bug.
Keywords: helpwanted
QA Contact: mattyt-bugzilla → default-qa
Assignee: john → attach-and-request
These parameters are gone, see bug 1068494.
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: helpwanted
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.