Closed Bug 232247 Opened 21 years ago Closed 21 years ago

Merge jsdom and gklayout libraries

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

Attachments

(1 file)

In the interest of sharing more code and further deCOMtamination, I'd like to merge jsdom into gklayout. Patch coming up.
Attached patch patchSplinter Review
Some notes: - nsScriptNameSpaceMaager.* would be moved in cvs rather than deleted and re-added - I moved nsDOMScriptObjectFactory into its own file because I didn't see a real reason for it to be in the module file (and layout's is already big enough)
Attachment #139933 - Flags: superreview?(jst)
Attachment #139933 - Flags: review?(dbaron)
The files that are "moved" by this patch should be copied in the repository before this is checked in so that we don't loose the CVS history for those files.
It'd be interesting to know what sharing and deCOMtamination this is going to allow.
One of the cases of deCOMtamination is noted in nsElementSH::PostCreate. Other than that, I wanted to be able to share some event dispatch code between GlobalWindow and the document/element classes without resorting to virtual functions.
Comment on attachment 139933 [details] [diff] [review] patch sr=jst with the files moved in the repository.
Attachment #139933 - Flags: superreview?(jst) → superreview+
Checked in, along with corresponding Camino project changes.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: