Closed
Bug 232247
Opened 20 years ago
Closed 20 years ago
Merge jsdom and gklayout libraries
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
Attachments
(1 file)
129.44 KB,
patch
|
dbaron
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In the interest of sharing more code and further deCOMtamination, I'd like to merge jsdom into gklayout. Patch coming up.
Assignee | ||
Comment 1•20 years ago
|
||
Some notes: - nsScriptNameSpaceMaager.* would be moved in cvs rather than deleted and re-added - I moved nsDOMScriptObjectFactory into its own file because I didn't see a real reason for it to be in the module file (and layout's is already big enough)
Assignee | ||
Updated•20 years ago
|
Attachment #139933 -
Flags: superreview?(jst)
Attachment #139933 -
Flags: review?(dbaron)
Comment 2•20 years ago
|
||
The files that are "moved" by this patch should be copied in the repository before this is checked in so that we don't loose the CVS history for those files.
Comment 3•20 years ago
|
||
It'd be interesting to know what sharing and deCOMtamination this is going to allow.
Assignee | ||
Comment 4•20 years ago
|
||
One of the cases of deCOMtamination is noted in nsElementSH::PostCreate. Other than that, I wanted to be able to share some event dispatch code between GlobalWindow and the document/element classes without resorting to virtual functions.
Updated•20 years ago
|
Attachment #139933 -
Flags: review?(dbaron) → review+
Comment 5•20 years ago
|
||
Comment on attachment 139933 [details] [diff] [review] patch sr=jst with the files moved in the repository.
Attachment #139933 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 6•20 years ago
|
||
Checked in, along with corresponding Camino project changes.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•