Merge jsdom and gklayout libraries

RESOLVED FIXED

Status

()

RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: bryner, Assigned: bryner)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
In the interest of sharing more code and further deCOMtamination, I'd like to
merge jsdom into gklayout.  Patch coming up.
(Assignee)

Comment 1

15 years ago
Created attachment 139933 [details] [diff] [review]
patch

Some notes:

- nsScriptNameSpaceMaager.* would be moved in cvs rather than deleted and
re-added
- I moved nsDOMScriptObjectFactory into its own file because I didn't see a
real reason for it to be in the module file (and layout's is already big
enough)
(Assignee)

Updated

15 years ago
Attachment #139933 - Flags: superreview?(jst)
Attachment #139933 - Flags: review?(dbaron)
The files that are "moved" by this patch should be copied in the repository
before this is checked in so that we don't loose the CVS history for those files.
It'd be interesting to know what sharing and deCOMtamination this is going to allow.
(Assignee)

Comment 4

15 years ago
One of the cases of deCOMtamination is noted in nsElementSH::PostCreate.  Other
than that, I wanted to be able to share some event dispatch code between
GlobalWindow and the document/element classes without resorting to virtual
functions.
Attachment #139933 - Flags: review?(dbaron) → review+
Comment on attachment 139933 [details] [diff] [review]
patch

sr=jst with the files moved in the repository.
Attachment #139933 - Flags: superreview?(jst) → superreview+
(Assignee)

Comment 6

15 years ago
Checked in, along with corresponding Camino project changes.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.