Closed Bug 232254 Opened 21 years ago Closed 20 years ago

forms / scrollbar broken on minimo

Categories

(Minimo Graveyard :: Build Config, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Whiteboard: [patch])

Attachments

(1 file, 1 obsolete file)

forms and the scrollbar are broken on minimo builds since there is no chrome
registry.  This is happening for a bunch of reasons:

 * when bsmedberg made changes to the chrome registry, he made things so the
minimo chrome registry was built whenever MOZ_XUL is not defined, and the
regular chrome registry is not built whenever it is defined.

 * when dougt landed the minimo app, he made some weird changes to the toplevel
makefile that broke the build order -- chromelite needs to be built before
embedding/browser/gtk/src/, because that (ugh!) is where the embed-link-comps
list is built

Furthermore, the stuff in embedding/browser/gtk/source/ has an |ifdef MINIMO|,
but |ifdef MINIMO| doesn't work in makefiles.

So I have a patch to do a bunch of things:
 * restore toplevel makefile to how it should be (chromelite before apps, minimo
app in tier_99 like other apps and not floating between rules)

 * make |ifdef MINIMO| do something in makefiles (which means minimo builds will
use minimo-unix instead of basebrowser-unix, and the minimo app will be built
for minimo builds)

 * add chromelite to basebrowser-unix in addition to minimo-unix, since the
chromelite library can be needed in non-MINIMO situations

I think that's it.
Attached patch patch (obsolete) — Splinter Review
I haven't yet tested the part that makes MINIMO be defined in makefiles, but
the rest of it does fix scrollbars and forms.
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
(BTW, the existing MINIMO ifdefs should work if you set MINIMO in your
environment, but not in a mozconfig file.)
Attached patch patchSplinter Review
These changes are still needed after what dougt just landed in order to:
 * make MINIMO=1 work from a mozconfig
 * unbreak --disable-xul for the non-MINIMO case
dougt, could you review the previous patch?
Comment on attachment 139943 [details] [diff] [review]
patch

minimo isn't going to use mozilla/Makefile.in to build itself.	you are going
to have to cd into mozilla/embedding/minimo after the top level build.

I am not sure why you are using chrmlite in the basebrowser.  chromelite is
specifically for the minimo application.
bsmedberg decided to stop trying to maintain the MOZ_XUL ifdefs in
nsChromeRegistry.cpp when he could just use chromelite for the --disable-xul
case.  That seems reasonable to me.
I am not going to support chromelite for all MOZ_XUL apps, just minimo (if it
works, great)  Alec has some goal to do this with another chrome implementation.  

in any case, I checked in a fix for this problem.
What fix did you check in?
Comment on attachment 139943 [details] [diff] [review]
patch

spoke to david in person.  We probably should move chromelite somewhere outside
of minimo -- or wait until there is a better chrome impl (maybe the one alecf
started on.)

In any case, looks fine r=dougt.  update before checking in.
Patch checked in 2004-02-01 15:22/23 -0800, and original bug fixed previously.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: