Closed
Bug 232254
Opened 21 years ago
Closed 21 years ago
forms / scrollbar broken on minimo
Categories
(Minimo Graveyard :: Build Config, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file, 1 obsolete file)
4.25 KB,
patch
|
Details | Diff | Splinter Review |
forms and the scrollbar are broken on minimo builds since there is no chrome
registry. This is happening for a bunch of reasons:
* when bsmedberg made changes to the chrome registry, he made things so the
minimo chrome registry was built whenever MOZ_XUL is not defined, and the
regular chrome registry is not built whenever it is defined.
* when dougt landed the minimo app, he made some weird changes to the toplevel
makefile that broke the build order -- chromelite needs to be built before
embedding/browser/gtk/src/, because that (ugh!) is where the embed-link-comps
list is built
Furthermore, the stuff in embedding/browser/gtk/source/ has an |ifdef MINIMO|,
but |ifdef MINIMO| doesn't work in makefiles.
So I have a patch to do a bunch of things:
* restore toplevel makefile to how it should be (chromelite before apps, minimo
app in tier_99 like other apps and not floating between rules)
* make |ifdef MINIMO| do something in makefiles (which means minimo builds will
use minimo-unix instead of basebrowser-unix, and the minimo app will be built
for minimo builds)
* add chromelite to basebrowser-unix in addition to minimo-unix, since the
chromelite library can be needed in non-MINIMO situations
I think that's it.
Assignee | ||
Comment 1•21 years ago
|
||
I haven't yet tested the part that makes MINIMO be defined in makefiles, but
the rest of it does fix scrollbars and forms.
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
Assignee | ||
Comment 2•21 years ago
|
||
(BTW, the existing MINIMO ifdefs should work if you set MINIMO in your
environment, but not in a mozconfig file.)
Assignee | ||
Comment 3•21 years ago
|
||
These changes are still needed after what dougt just landed in order to:
* make MINIMO=1 work from a mozconfig
* unbreak --disable-xul for the non-MINIMO case
Assignee | ||
Updated•21 years ago
|
Attachment #139942 -
Attachment is obsolete: true
Assignee | ||
Comment 4•21 years ago
|
||
dougt, could you review the previous patch?
Comment 5•21 years ago
|
||
Comment on attachment 139943 [details] [diff] [review]
patch
minimo isn't going to use mozilla/Makefile.in to build itself. you are going
to have to cd into mozilla/embedding/minimo after the top level build.
I am not sure why you are using chrmlite in the basebrowser. chromelite is
specifically for the minimo application.
Assignee | ||
Comment 6•21 years ago
|
||
bsmedberg decided to stop trying to maintain the MOZ_XUL ifdefs in
nsChromeRegistry.cpp when he could just use chromelite for the --disable-xul
case. That seems reasonable to me.
Comment 7•21 years ago
|
||
I am not going to support chromelite for all MOZ_XUL apps, just minimo (if it
works, great) Alec has some goal to do this with another chrome implementation.
in any case, I checked in a fix for this problem.
Assignee | ||
Comment 8•21 years ago
|
||
What fix did you check in?
Comment 9•21 years ago
|
||
Comment on attachment 139943 [details] [diff] [review]
patch
spoke to david in person. We probably should move chromelite somewhere outside
of minimo -- or wait until there is a better chrome impl (maybe the one alecf
started on.)
In any case, looks fine r=dougt. update before checking in.
Assignee | ||
Comment 10•21 years ago
|
||
Patch checked in 2004-02-01 15:22/23 -0800, and original bug fixed previously.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•