232299 - correct the "Personal Toolbar Bookmark Folders" phrase in help

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Joe Infla]

The listed lxr search shows a phrase & subject heading "Adding Personal Toolbar
Bookmark Folders."  This should be changed.  See bug 231835 comment 4 through 7
for more info.

The entry:
-----------
Adding Personal Toolbar Bookmark Folders

You can add bookmark folders to the Personal Toolbar to sort your favorite
bookmarks into categories. For example, you can have one folder on the Personal
Toolbar for hobby-related bookmarks and another folder for work-related
bookmarks. To add a new bookmark to the Personal Toolbar:

   1. Open the Bookmarks menu and choose Manage Bookmarks.
   2. Select your designated "Personal Toolbar Folder."
   3. Click New Folder on the toolbar.
   4. Type a name for your new bookmark folder. By default, the name is "New
Folder."
   5. Click OK to confirm your new bookmark folder name.

The new bookmark folder will appear at the end of the Personal Toolbar.
-----------

Comment 1

[Joe Infla]

Attachment: change section title & references to it

I think this change clarifies the section while introducing the least
inconsistency in phrasing.  I changed "Adding Personal Toolbar Bookmark
Folders" to "Adding Bookmark Folders to the Personal Toolbar."

Other possibilities:
1. Remove 'Bookmark' from title.  This could be confused with the subject of
the next help entry, "Designating a Bookmark Folder as Your Personal Toolbar
Folder."
2. Change to "Adding Folders to the Personal Toolbar."	Simpler, but less
consistent with the rest of Help, where folders to contain bookmarks are always
referred to as Bookmark Folders.

I think the form in this patch is best, overall.  Its only inconsistency is
with the prior help entry, "Adding Personal Toolbar Bookmarks."

Comment 2

[R.J. Keller]

Comment on attachment 140004 [details] [diff] [review]
change section title & references to it

r=[e-mail],

I definetely agree. This is much better phrasing.

Thanks for the patch!

Comment 3

[R.J. Keller]

Fix checked in.

Comment 4

[R.J. Keller]

Reopening bug. Drivers approval is required for checkin.

Comment 5

[chris hofmann]

Comment on attachment 140004 [details] [diff] [review]
change section title & references to it

a=chofmann

Comment 6

[Daniel Wang]

rlk, can you check in the patch?

Comment 7

[R.J. Keller]

Sorry, I checked in the patches for these bugs again and forgot to post a
comment ;). They've been in for awhile.

Comment 8

[Stefan [:stefanh]]

Reopening, since this never got fixed. The patch was only for the file with
.xhtml suffix -- a file that wasn't in use. customize_help is now converted to
xhtml. Since the html file was used for the conversion you'll still se the wrong
phrases.

Comment 9

[Stefan [:stefanh]]

The patch in bug 249577 will fix this.

Comment 10

[Stefan [:stefanh]]

Fixed by the check-in of the patch in bug 249577.