Closed Bug 232327 Opened 20 years ago Closed 20 years ago
In bug 215985, I slightly goofed. |return| is not technically valid outside of a JS function. I'd like to change the JS in the URL we give for mapping window._content to be valid. Patch forthcoming.
20 years ago
The NS_LITERAL_STRING is the body of the function we're compiling and is thus still correct. Because we're compiling this as a function, I'd rather go with the patch, which keeps it a function, but I could change it if so desired.
I must admit part of me wants to go with shaver's other suggestion of naming the function _content (it even looks cooler than what I have currently), but I'll certainly buy into readability. It does work, and it is a valid point that the user may not understand/care to see more than that. New patch coming up.
Comment on attachment 140003 [details] [diff] [review] As per shaver Ok, lets give this a whirl.
Comment on attachment 140003 [details] [diff] [review] As per shaver I obviously like it. =)
Attachment #140003 - Flags: review?(shaver) → review+
Comment on attachment 140003 [details] [diff] [review] As per shaver What does the // See " __FILE__, mean now? Is it just a holdover? It looks odd, what with the "" and the trailing comma. Lose that and sr=me. /be
Attachment #140003 - Flags: superreview?(brendan) → superreview+
What shaver said. :-)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.