232343 - spell checker broken

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Scott MacGregor]

hangs in an infinite loop spell checking the first misspelled word

I don't think the recent string useage changes in this file would cause this...

Comment 1

[Scott MacGregor]

I think bug 230840 caused this. more info coming soon

Comment 2

[Scott MacGregor]

cc'ing Johnny, this loop in the spell checker happened in the builds the morning
after the landing for nsIContentIterator which is used by nsTextServicesDocument
to iterate over the document for the spell checker. AFter that landing we are no
longer iterating to the next word in the document. Looks like the iterator stays
on  the same word. 

Comment 3

[Johnny Stenback (:jst)]

Investigating.

Comment 4

[Johnny Stenback (:jst)]

Hmm, I'm unable to reproduce this hang, using Mail Compose (both plain text and
HTML) in SeaMonkey. Got a stacktrace, or more detailed instructions?

Comment 5

[Scott MacGregor]

the key is to have at least one misspelled message in the compose window and
then you have to send the message. This also implies that you have spell check
on send set to true.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

I could reproduce with seamonkey when spellchecking a few lines. jsut one or two
words didn't work, i needed more. I added a few newlines too. Make sure you have
at least a few wrong words. Ignore the misspellings. Now, spellchecks just loops
and loops. It will start at the beginning after a few words.

Comment 7

[Johnny Stenback (:jst)]

Ok, I'm seeing it now. Working on a fix.

Comment 8

[Johnny Stenback (:jst)]

Attachment: Fix nsTextServicesDocument::GetFirstTextNodeInPrevBlock().

Comment 9

[Johnny Stenback (:jst)]

Comment on attachment 140015 [details] [diff] [review]
Fix nsTextServicesDocument::GetFirstTextNodeInPrevBlock().

The patch in bug 230840 incorrectly made
nsTextServicesDocument::GetFirstTextNodeInPrevBlock() position the iterator at
the first text node in the previous block, when all it should do was return the
node.

Comment 10

[Scott MacGregor]

Comment on attachment 140015 [details] [diff] [review]
Fix nsTextServicesDocument::GetFirstTextNodeInPrevBlock().

thanks johnny

Comment 11

[Oleg Sidletskiy]

this is probably related to Bug 232173

Comment 12

[Johnny Stenback (:jst)]

Fixed.

Comment 13

[Scott MacGregor]

*** Bug 232173 has been marked as a duplicate of this bug. ***

Comment 14

[lohphat]

Confirmed fixed in 2004012808 win32 build.  Thanks guys.

Comment 15

[R.K.Aa.]

*** Bug 232724 has been marked as a duplicate of this bug. ***