23237 - Fix all of the base classes that don't have a specifier

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Jim Dunn]

There are lots of classes that specify a base class but don't
indicate whether it is public or private.  AIX assumes that
it is private, but I am not sure if that is a good assumption.
My intention is to list all of them here and mark them
'public'.  I will also copy everyone who owns one of the files.

Comment 1

[Jim Dunn]

"nsPSMDetectors.cpp", line 321.7: 1540-001: (W) "private" assumed for base class
"nsPSMDetector".
"nsPSMDetectors.cpp", line 392.7: 1540-001: (W) "private" assumed for base class
"nsPSMDetector".
"xpctest_inout.cpp", line 39.22: 1540-001: (W) "private" assumed for base class
"nsIXPCTestInOut".
"xpctest_multiple.cpp", line 172.48: 1540-001: (W) "private" assumed for base
class "nsIXPCTestParentOne".
"xpctest_multiple.cpp", line 172.69: 1540-001: (W) "private" assumed for base
class "nsIXPCTestParentTwo".
"xpctest_multiple.cpp", line 394.48: 1540-001: (W) "private" assumed for base
class "xpcTestParentOne".
"xpctest_multiple.cpp", line 394.66: 1540-001: (W) "private" assumed for base
class "xpcTestParentTwo".
"xpctest_multiple.cpp", line 464.48: 1540-001: (W) "private" assumed for base
class "xpcTestParentTwo".
"../../dist/include/nsCertificatePrincipal.h", line 35.64: 1540-001: (W)
"private" assumed for base class "nsBasePrincipal".
"../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private"
assumed for base class "nsICodebasePrincipal".
"../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private"
assumed for base class "nsICodebasePrincipal".
"../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private"
assumed for base class "nsICodebasePrincipal".
"../../dist/include/nsCodebasePrincipal.h", line 37.53: 1540-001: (W) "private"
assumed for base class "nsICodebasePrincipal".
"nsSliderFrame.h", line 51.30: 1540-001: (W) "private" assumed for base class
"nsIDOMMouseListener".
"nsSliderFrame.h", line 52.30: 1540-001: (W) "private" assumed for base class
"nsIAnonymousContentCreator".
"nsSliderFrame.h", line 53.30: 1540-001: (W) "private" assumed for base class
"nsITimerCallback".
"nsScrollbarFrame.cpp", line 51.47: 1540-001: (W) "private" assumed for base
class "nsIStyledContent".
"nsScrollbarFrame.cpp", line 51.65: 1540-001: (W) "private" assumed for base
class "nsIAnonymousContent".
"nsSliderFrame.h", line 51.30: 1540-001: (W) "private" assumed for base class
"nsIDOMMouseListener".
"nsSliderFrame.h", line 52.30: 1540-001: (W) "private" assumed for base class
"nsIAnonymousContentCreator".
"nsSliderFrame.h", line 53.30: 1540-001: (W) "private" assumed for base class
"nsITimerCallback".
"nsRDFDOMViewerUtils.h", line 29.27: 1540-001: (W) "private" assumed for base
class "nsIRDFDOMViewerObject".
"nsRDFDOMResourceFactory.h", line 33.31: 1540-001: (W) "private" assumed for
base class "nsRDFResource".
"nsRDFDOMResourceFactory.h", line 34.31: 1540-001: (W) "private" assumed for
base class "nsIDOMViewerElement".
"nsRDFDOMViewerUtils.h", line 29.27: 1540-001: (W) "private" assumed for base
class "nsIRDFDOMViewerObject".
"nsInternetSearchService.cpp", line 215.59: 1540-001: (W) "private" assumed for
base class "nsIStreamListener".
"nsMsgWindow.h", line 36.42: 1540-001: (W) "private" assumed for base class
"nsIURIContentListener".
"nsMimeBaseEmitter.h", line 67.50: 1540-001: (W) "private" assumed for base
class "nsIPipeObserver".
"nsSmtpService.cpp", line 222.25: 1540-001: (W) "private" assumed for base class
"nsIChannel".
"nsMsgComposeService.h", line 28.58: 1540-001: (W) "private" assumed for base
class "nsIContentHandler".
"TestXPTCInvoke.cpp", line 478.20: 1540-001: (W) "private" assumed for base
class "FooImpl".
"TestXPTCInvoke.cpp", line 478.29: 1540-001: (W) "private" assumed for base
class "BarImpl".

Comment 2

[Jim Dunn]

I am getting back lots of okays...

r= [e-mail]
r= [e-mail]

Comment 3

[Jim Dunn]

Attachment: Proposed Fix

Comment 4

[Jim Dunn]

r= [e-mail] for
intl/chardet/src/nsPSMDetectors.cpp line 321 & 392. they
are private!

Comment 5

[Jim Dunn]

Checked in on 1/10.
if this stuff builds... I would say it is QA'd!

Comment 6

[leger]

Adding verifyme keyword.

Comment 7

[Jim Dunn]

marking verified

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/fe0a2b2fc78a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/23237 minor refactoring work for privateTabsTrayWithOpenedTabTest UI test